Repository navigation
make support sld 1.1 version + rework remove_attributes_element function - #123
Merged
Merged
Conversation
mki-c2c
approved these changes
May 29, 2026
mki-c2c
left a comment
mki-c2c
left a comment
Contributor
There was a problem hiding this comment.
All seems fine to me, function wise I cannot tell, it has to be tested on the platform integration
| style_format = style_info["style"]["format"] | ||
| # differentiation of the style version : | ||
| # https://docs-archive.geoserver.org/stable/en/user/rest/api/styles.html#styles-post-and-put | ||
| if style_info["style"]["languageVersion"]["version"] == "1.1.0": |
Contributor
There was a problem hiding this comment.
is "languageVersion" always returned in the output json ?
or would it be preferable to use if style_info["style"].get("languageVersion", {}).get("version") ??
Contributor
Author
There was a problem hiding this comment.
it is always return as style_info["style"]["format"] but okay i can use your style
| # https://docs-archive.geoserver.org/stable/en/user/rest/api/styles.html#styles-post-and-put | ||
| if style_info["style"]["languageVersion"]["version"] == "1.1.0": | ||
| style_format = "htlm" | ||
| header = {"Accept": "application/vnd.ogc.se+xml"} |
Contributor
There was a problem hiding this comment.
headers in plural for consistency ?
Suggested change
| header = {"Accept": "application/vnd.ogc.se+xml"} | |
| headers = {"Accept": "application/vnd.ogc.se+xml"} |
jeanmi151
force-pushed
the
support_for_sld11
branch
from
May 29, 2026 07:57
f482f93 to
245c76b
Compare
Contributor
Author
|
Just tested it is working with my last modification |
jeanmi151
force-pushed
the
support_for_sld11
branch
2 times, most recently
from
May 29, 2026 09:00
7f11ec1 to
1e34ab6
Compare
jeanmi151
force-pushed
the
support_for_sld11
branch
from
May 29, 2026 09:09
1e34ab6 to
6d0c58f
Compare
jeanmi151
changed the title
jeanmi151
added a commit
that referenced
this pull request
May 29, 2026
…ion (#123) * make support SLD 1.1 version * rework remove_attributes_element as it was introducing a bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entry point of the sld is different depending on it version,
with that code I successfully transfer a 1.1.0 sld file