Repository navigation
Conversation
…lations dynammicaly and merge them
which aligns all translation values from markers kept in former metadata.i18n.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frontend now uses its own
TranslateLoader, which merges the geonetwork-ui translations (copied toassets/i18n/gn-ui/at build time) with datafeeder's. Datafeeder values take precedence, and empty values are ignored.This removes the duplicated gn-ui markers (
metadata.i18n.ts) and their translations fromtranslations/*.json. Languages other than en/fr now get gn-ui's translations instead of falling back to English.gn-ui has been updated to align all translation values that corresponded to markers kept in the deleted
metadata.i18n.ts.Translation overrides
gn-ui translation values can still be overridden as before by adding markers to components that use gn-ui components. These overrides will be applied to datafeeder in general.
The overrides currently present in the datafeeder (and that were not touched in this PR) are:
input.file.selectFileLabelinput.file.orInputUrlinput.file.selectFileLabelinput.file.dropFileLabelinput.file.orInputUrlIf these were not done intentionally they can still (partially) be dropped.
Note: A follow-up PR (that will load the gn-ui default.toml config) will allow to override translations by datafeeder instance.