Repository navigation
Conversation
A "Join" toggle next to the dataset title opens a section to pick a reference table (dataset title, table name as subtitle), the source and reference join keys, then the columns to add. Changing the table resets the reference key and the added columns. The toggle shows a marker while columns are added. The join is saved in the transformation only once a column is added. Joined columns are shown read-only and in green after the source columns of the preview, which scrolls to the right on each addition. A joined column named like an output column of the preview is flagged like a duplicate rename: it blocks validation and is left out of the saved join. As in the backend, excluded columns do not count, and geom is taken when the point is built from X/Y. Failing to load the joinable tables or columns shows an error above the step. The wizard now renders a single preview table instead of one per geographic branch, so adding a joined geom no longer recreates it. GSMEL-1223
tonio
force-pushed
the
feat/GSMEL-1223
branch
from
October 14, 2026 12:28
f7abe10 to
6539491
Compare
tonio
marked this pull request as ready for review
October 14, 2026 13:03
tkohr
approved these changes
Oct 19, 2026
tkohr
left a comment
tkohr
left a comment
Contributor
There was a problem hiding this comment.
Thanks @tonio, nice feature with clear UX ! The code LGTM, just left some minor comments inline.
Works mostly flawless, the only things I noticed testing:
- Couldn't change the column name of a column with a naming conflict as the input is not editable (see screenshot below)
- Keyboard arrow navigation on dataset selection does not seem to work
- Our gn-ui dropdowns do not seem to support selecting an option by typing its value, which can be practical in long lists (not related to this PR though)
| <gn-ui-button | ||
| data-test="join-toggle" | ||
| type="outline" | ||
| extraClass="h-14" |
Contributor
There was a problem hiding this comment.
Could also be achieved via the css var approach I think:
Suggested change
| extraClass="h-14" | |
| [style.--gn-ui-button-height]="'3.5rem'" |
| this.saveConfigAndRefresh() | ||
| } | ||
|
|
||
| async toggleJoin(): Promise<void> { |
Contributor
There was a problem hiding this comment.
I've noticed that there is a lot of join logic in the wizard component now and was wondering if there'd be a way to move some of it out of there!?
| <gn-ui-button | ||
| data-table-select | ||
| type="outline" | ||
| extraClass="bg-background flex flex-row w-full" |
Contributor
There was a problem hiding this comment.
Could probably also be achieved in the style binding if it's not already part of the gn-ui-button style.
| } | ||
| </div> | ||
|
|
||
| <ng-template |
Contributor
There was a problem hiding this comment.
Why don't we use a gn-ui-dropdown-selector for the first dropdown? I've noticed that I can't navigate with the keyboard arrows in this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GSMEL-1223: define a join in the preview step
Based on #185 (backend: join config, LEFT JOIN in preview, joinable tables/columns endpoints). Merge that one first.
What
Rules
geomis taken when the point is built from X/Y.Notes
geomno longer recreates it and loses the scroll.app-dataset-titleto stay aligned with the title field, with or without a validation error.Test
geom. The preview fills the green columns and the map tab becomes available.