Uninitialised memory read in readhdf5.C#243
Open
lispandfound wants to merge 1 commit into
Open
Conversation
The `hid_t` types `grp, dset, attr` are uninitialised, which compounds with a bug in the assertions that checks that the `attr` variable is read correctly instead of `dset`. For some combination of compile flags this results in the `attr` variable having positive garbage values meaning all the assertions are meaningless if none of the optional ISNSEW, WindowL, WindowR attributes are set. If you are unlucky compiling this code attr gets negative garbage values which results in a crash. Fix is to initialise datasets in the beginning and fix the assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
hid_ttypesgrp, dset, attrare uninitialised, which compounds with a bug in the assertions that checks that theattrvariable is read correctly instead ofdset. For some combination of compile flags this results in theattrvariable having positive garbage values meaning all the assertions are meaningless. If you are unlucky compiling this codeattrgets negative garbage values which results in a crash. Fix is to initialise datasets in the beginning and fix the assertions.