Prescribed condition with particles#7022
Open
lhy11009 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@gassmoeller @danieldouglas92 , maybe you two can take a look and decide whether this is the way, given your familiarity with the original PRs of the prescribed solution. |
danieldouglas92
approved these changes
Jul 12, 2026
Contributor
There was a problem hiding this comment.
@lhy11009 Nice addition and this looks good to me! The spherical sinker test failing seems to be unrelated to your changes and is failing in other PR's as well. Just one minor comment and I think this is good to go
bf604d0 to
cec2146
Compare
Contributor
Author
|
@danieldouglas92 Great! Thanks for your review. I have committed the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.
This PR extends the
InitialCompositionparticle property plugin to support updates from the prescribed solution framework during particle property updates. For each particle, the plugin queries the active prescribed solution plugins using the existingconstrain_solution()interface and overwrites only those compositional components that are actively constrained, leaving all other stored values unchanged.This might be a little tricky in terms of implementation, but it would be useful to bridge the current gap between the particle method and the prescribed solution.
The tricky part is that this is not actually a constraint that is applied to the solution; rather, this is a hard fix to the recorded compositions of the particles.
Before your first pull request:
For all pull requests:
For new features/models or changes of existing features: