Skip to content

Prescribed condition with particles#7022

Open
lhy11009 wants to merge 1 commit into
geodynamics:mainfrom
lhy11009:prescribed_solution_composition_particles
Open

Prescribed condition with particles#7022
lhy11009 wants to merge 1 commit into
geodynamics:mainfrom
lhy11009:prescribed_solution_composition_particles

Conversation

@lhy11009

@lhy11009 lhy11009 commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.

This PR extends the InitialComposition particle property plugin to support updates from the prescribed solution framework during particle property updates. For each particle, the plugin queries the active prescribed solution plugins using the existing constrain_solution() interface and overwrites only those compositional components that are actively constrained, leaving all other stored values unchanged.

This might be a little tricky in terms of implementation, but it would be useful to bridge the current gap between the particle method and the prescribed solution.

The tricky part is that this is not actually a constraint that is applied to the solution; rather, this is a hard fix to the recorded compositions of the particles.

Before your first pull request:

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

@lhy11009

Copy link
Copy Markdown
Contributor Author

@gassmoeller @danieldouglas92 , maybe you two can take a look and decide whether this is the way, given your familiarity with the original PRs of the prescribed solution.

@danieldouglas92 danieldouglas92 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhy11009 Nice addition and this looks good to me! The spherical sinker test failing seems to be unrelated to your changes and is failing in other PR's as well. Just one minor comment and I think this is good to go

@lhy11009 lhy11009 force-pushed the prescribed_solution_composition_particles branch from bf604d0 to cec2146 Compare July 12, 2026 18:59
@lhy11009

Copy link
Copy Markdown
Contributor Author

@danieldouglas92 Great! Thanks for your review. I have committed the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants