Avoid IdGroup in IsSymmetricGroup - #6383
Merged
Merged
Conversation
Based on experiments, just testing the order seemed to be fastest. Though of course it also depends on the representation used for the group.
ThomasBreuer
approved these changes
May 8, 2026
ThomasBreuer
left a comment
Contributor
There was a problem hiding this comment.
Iterating over the group looks horrible. What about stopping at the first element of order 6 (then we are sure the group is S6) or of order 8 or 10 (then we are sure the group is not S6)?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6383 +/- ##
=======================================
Coverage 78.69% 78.69%
=======================================
Files 684 684
Lines 292891 292897 +6
Branches 8686 8660 -26
=======================================
+ Hits 230497 230505 +8
+ Misses 60581 60577 -4
- Partials 1813 1815 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@ThomasBreuer good idea, done now |
cdwensley
pushed a commit
that referenced
this pull request
May 12, 2026
cdwensley
pushed a commit
that referenced
this pull request
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on experiments, just testing the order seemed to be fastest. Though of course it also depends on the representation used for the group.
With this many more packages pass test with
gap --bare.In my experiments the new code was never slower and sometimes faster than
IdGroup. For example, inmaster(the three groups used here are the ones of order 720 which contains an A6 of index 2)With this PR: