[cetteup]

Removed the (now obsolete) handling of keyhash duplicates. Tested successfully on a few servers.

The old code logged a debug message, should we add one here to match?

closes #743

[cetteup]

Turns out the old code (cd key hash deduplication) was an incomplete solution, as only some servers report the cd key hash. Meaning it still returned duplicate players for servers which do not report the key hash.

The new code reliability addresses the duplicates (which are stale entries with the same name).

[CosminPerRam]

Supposing the server always sends the stale data after the N reported players count, this is a great fix.
Everything LGTM, please also add a line in the changelog file.

[cetteup]

@CosminPerRam It's no more than a guess, but it might be that the server allocates a fixed-size array for the list of players. That array might only be implemented to be replaced when players join, not when players leave. So after a player leaves, the data for the remaining players is updated in the first n = numplayers entries of the array, while any entries after that remain as they last were without receiving further updates. This explanation does align with what I saw during testing. The only time the servers seem to reset/reallocate the array is at round end/map load.

Added a line to changelog now.