Repository navigation
Fix jME math API usage in physics joints - #1253
Closed
AlexisDrogoul wants to merge 1 commit into
Closed
AlexisDrogoul wants to merge 1 commit into
AlexisDrogoul wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The replacements match the bundled jME API signatures while preserving the intended transformations.
0 open findings
What changed in this PR
Updates physics joint math calls to match Libbulletjme 21.2.1 APIs and restore compilation.
Changes:
- Uses destination-parameter matrix multiplication overloads.
- Converts quaternions to rotation matrices before transforming vectors.
| File | Description |
|---|---|
NativeBulletPhysicalWorld.java |
Updates joint-frame matrix multiplication. |
GamaJoint.java |
Updates slider translation and axis transformations. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #748: use Matrix3f.mult(m, store) and Quaternion.toRotationMatrix().mult(v, store), which are the signatures available in Libbulletjme 21.2.1 (fixes compilation errors in NativeBulletPhysicalWorld and GamaJoint).