Skip to content

fix: _compile_tree to use depends_on for rtree.c instead of source_files - #54

Merged
tlambert03 merged 1 commit into
funkelab:mainfrom
tlambert03:fix-rtree
Jul 27, 2026
Merged

fix: _compile_tree to use depends_on for rtree.c instead of source_files#54
tlambert03 merged 1 commit into
funkelab:mainfrom
tlambert03:fix-rtree

Conversation

@tlambert03

Copy link
Copy Markdown
Member

fixing the broken tests

SRC_DIR / "src" / "rtree.c"

is #included and doesn't need to be listed as a compilation/link target.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.11%. Comparing base (32de8f7) to head (a048012).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          12       12           
  Lines         389      389           
=======================================
  Hits          370      370           
  Misses         19       19           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Jul 27, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing tlambert03:fix-rtree (a048012) with main (32de8f7)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (ddf69f3) during the generation of this report, so 32de8f7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@tlambert03
tlambert03 merged commit caab135 into funkelab:main Jul 27, 2026
21 checks passed
@tlambert03
tlambert03 deleted the fix-rtree branch July 27, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants