Skip to content

Use device-reported repo for firmware releases and upgrades #2049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
netmindz wants to merge 7 commits into from
Closed

Use device-reported repo for firmware releases and upgrades #2049

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cceb573
Use device-reported repo for firmware releases and upgrades
netmindz Apr 22, 2026
1471229
Add tests for device-reported repo field
netmindz Apr 22, 2026
85a5673
Update snapshots for Info.repo field
netmindz Apr 22, 2026
d6896c4
Update src/wled/models.py
netmindz Apr 25, 2026
eec1a6c
Apply suggestion from @Copilot
netmindz Apr 25, 2026
8f36752
move import statement
netmindz Apr 25, 2026
97b9a71
Fix constants
netmindz Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/wled/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from mashumaro.types import SerializableType, SerializationStrategy

from .const import (
DEFAULT_REPO,
MIN_REQUIRED_VERSION,
LightCapability,
LiveDataOverride,
Expand Down Expand Up @@ -489,6 +490,11 @@ class Info(BaseModel): # pylint: disable=too-many-instance-attributes
product: str = "DIY Light"
"""The product name. Always FOSS for standard installations."""

repo: str = field(default=DEFAULT_REPO, metadata=field_options(alias="repo"))
"""GitHub repository in 'org/repo' format reported by the device firmware.
Used in preference to the default repo when fetching releases or upgrading.
Comment thread
netmindz marked this conversation as resolved.
Outdated
"""

Comment thread
frenck marked this conversation as resolved.
release: str | None = None
"""The release name of the firmware build.

Expand Down
4 changes: 4 additions & 0 deletions src/wled/wled.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,10 @@ async def upgrade( # noqa: PLR0912
msg = "Device already running the requested version"
raise WLEDUpgradeError(msg)

# Prefer the repo reported by the device itself; older firmware that does
# not include the field will have fallen back to DEFAULT_REPO already.
repo = self._device.info.repo
Comment thread
netmindz marked this conversation as resolved.
Outdated

# Determine if this is an Ethernet board
ethernet = ""
if (
Expand Down
Loading