Skip to content

Allow spaces in user names and auto-generate login #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carma12 merged 1 commit into from
Aug 14, 2026
+61 −41
Merged

Allow spaces in user names and auto-generate login #1158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 40 additions & 41 deletions src/components/modals/UserModals/AddUser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { useAppDispatch, useAppSelector } from "src/store/hooks";
// RPC
import {
useSimpleMutCommandMutation,
useGetObjectMetadataQuery,
Command,
FindRPCResponse,
} from "src/services/rpc";
Expand All @@ -28,6 +29,7 @@ import ErrorModal from "src/components/modals/ErrorModal";
import { addAlert } from "src/store/Global/alerts-slice";
// Utils
import { NO_SELECTION_OPTION } from "src/utils/constUtils";
import { generateLogin } from "src/utils/loginUtils";
// Components
import TypeAheadSelectWithCreate from "src/components/TypeAheadSelectWithCreate";
import InputWithValidation from "src/components/layouts/InputWithValidation";
Expand Down Expand Up @@ -58,13 +60,17 @@ const AddUser = (props: PropsToAddUser) => {
(state) => state.global.environment.api_version
) as string;

// [API call] Metadata
const metadataQuery = useGetObjectMetadataQuery();
const metadata = metadataQuery.data || {};

// Define 'executeCommand' to add user data to IPA server
const [addUser] = useAddUserMutation();
// Define handler to execute when getting gids
const [retrieveGIDs] = useSimpleMutCommandMutation();

// useStates for TextInputs
const [userLogin, setUserLogin] = React.useState("");
const [customLogin, setCustomLogin] = React.useState("");
const [firstName, setFirstName] = React.useState("");
const [lastName, setLastName] = React.useState("");
const [userClass, setUserClass] = React.useState("");
Expand All @@ -74,6 +80,13 @@ const AddUser = (props: PropsToAddUser) => {
const [verifyNewPassword, setVerifyNewPassword] = React.useState("");
const [addSpinning, setAddBtnSpinning] = React.useState<boolean>(false);

// Generated login shown as placeholder; used as fallback on submit
const generatedLogin = generateLogin(firstName, lastName);

const handleLoginChange = (value: string) => {
setCustomLogin(value);
};

const newPasswordValueHandler = (value: string) => {
setNewPassword(value);
};
Expand All @@ -82,12 +95,16 @@ const AddUser = (props: PropsToAddUser) => {
setVerifyNewPassword(value);
};

// User login: Valid characters in first char: ., _
const userLoginFormatFirst = /^([A-Za-z._]).*$/;
// User login: Valid characters in body (every char must be in set): letters, digits, '_', '-', '.', '$'
const userLoginFormatBody = /^[A-Za-z0-9._\-$]*$/;
// Valid characters: '-' symbols only
const formatWithoutSpaces = /[`!@#$%^&*()_+=[\]{};':"\\|,.<>/?~\s]/;
// User login pattern from server metadata (falls back to hardcoded default)
const uidParam = metadata.objects?.user?.takes_params?.find(
(param) => param.name === "uid"
);
const userLoginPattern = uidParam?.pattern
? new RegExp(uidParam.pattern)
: /(?!^[0-9]+$)^[a-zA-Z0-9_.][a-zA-Z0-9_.-]*[a-zA-Z0-9_.$-]?$/;
const userLoginPatternErrMsg =
uidParam?.pattern_errmsg ||
"may only include letters, numbers, _, -, . and $";

// [API call] Get GIDs
const getGIDs = () => {
Expand Down Expand Up @@ -154,9 +171,8 @@ const AddUser = (props: PropsToAddUser) => {
// Buttons are disabled until the user fills the required fields
const buttonDisabled = !(
firstName.length > 0 &&
!formatWithoutSpaces.test(firstName) &&
lastName.length > 0 &&
!formatWithoutSpaces.test(lastName) &&
(customLogin === "" || userLoginPattern.test(customLogin)) &&
verifiedPasswords &&
(isNoPrivateGroupChecked === true ? gidSelected !== "" : true)
);
Expand All @@ -183,16 +199,14 @@ const AddUser = (props: PropsToAddUser) => {
dataCy="modal-textbox-login"
id="modal-form-user-login"
name="modal-form-user-login"
isRequired
value={userLogin}
onChange={setUserLogin}
value={customLogin}
placeholder={generatedLogin}
onChange={handleLoginChange}
rules={[
{
id: "ruleCharacters",
message: "Only alphanumeric and special characters _-.$",
validate: (v: string) =>
userLoginFormatFirst.test(v.charAt(0)) &&
userLoginFormatBody.test(v.substring(1)),
message: userLoginPatternErrMsg,
validate: (v: string) => userLoginPattern.test(v),
},
]}
/>
Expand All @@ -202,21 +216,13 @@ const AddUser = (props: PropsToAddUser) => {
id: "modal-form-first-name",
name: "First name",
pfComponent: (
<InputWithValidation
dataCy="modal-textbox-first-name"
<TextInput
data-cy="modal-textbox-first-name"
id="modal-form-first-name"
name="modal-form-first-name"
value={firstName}
onChange={setFirstName}
onChange={(_event, value: string) => setFirstName(value)}
isRequired
rules={[
{
id: "ruleCharacters",
message:
"First name should not contain special characters or spaces",
validate: (v: string) => !formatWithoutSpaces.test(v),
},
]}
/>
),
fieldRequired: true,
Expand All @@ -225,21 +231,13 @@ const AddUser = (props: PropsToAddUser) => {
id: "modal-form-last-name",
name: "Last name",
pfComponent: (
<InputWithValidation
dataCy="modal-textbox-last-name"
<TextInput
data-cy="modal-textbox-last-name"
id="modal-form-last-name"
name="modal-form-last-name"
value={lastName}
onChange={setLastName}
onChange={(_event, value: string) => setLastName(value)}
isRequired
rules={[
{
id: "ruleCharacters",
message:
"Last name should not contain special characters or spaces",
validate: (v: string) => !formatWithoutSpaces.test(v),
},
]}
/>
),
fieldRequired: true,
Expand Down Expand Up @@ -362,8 +360,9 @@ const AddUser = (props: PropsToAddUser) => {
sn: lastName,
};

if (userLogin !== "") {
newUserPayload.uid = userLogin;
const effectiveLogin = customLogin || generatedLogin;
if (effectiveLogin !== "") {
newUserPayload.uid = effectiveLogin;
}

if (userClass !== "") {
Expand Down Expand Up @@ -421,7 +420,7 @@ const AddUser = (props: PropsToAddUser) => {

// Helper method to clean the fields
const cleanAllFields = () => {
setUserLogin("");
setCustomLogin("");
setFirstName("");
setLastName("");
setUserClass("");
Expand Down
21 changes: 21 additions & 0 deletions src/utils/loginUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
/**
* Strips diacritics and removes characters not valid in a FreeIPA login.
*/
export const sanitizeLoginPart = (s: string): string =>
s
.normalize("NFD")
.replace(/[\u0300-\u036f]/g, "")
.replace(/[^A-Za-z0-9._\-$]/g, "")
.toLowerCase();

/**
* Generates a sanitized login from first + last name,
* matching FreeIPA's default: givenname[0] + sn (lowercased).
*/
export const generateLogin = (first: string, last: string): string => {

@duzda duzda Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need for this code, please don't generate login on the frontend, it will be handled by backend if you omit it.

@carma12 carma12 Aug 13, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that the server's auto-generation (givenname[0] + sn) does not sanitize, it just concatenates as-is. So with sn="Rodriguez Perez", the server would try to create login mrodriguez perez, which then fails its own pattern validation because spaces aren't allowed in a uid.

Another example:

>> ipa user-add
First name: Anselmo
Last name: Luján Espósito
User login [aluján espósito]: 
ipa: ERROR: invalid 'login': may only include letters, numbers, _, -, . and $, refer to 'ipa help user' for complete format description

The generateLogin function aims to fix that.

@duzda duzda Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please raise an issue on the backend then?

const sanitizedFirst = sanitizeLoginPart(first);
const sanitizedLast = sanitizeLoginPart(last);

if (!sanitizedFirst || !sanitizedLast) return "";
return sanitizedFirst.charAt(0) + sanitizedLast;
};
Loading