Add tests for OTP tokens pages by carma12 · Pull Request #1149 · freeipa/freeipa-webui

carma12 · 2026-08-07T11:08:16Z

The tests should cover all the use cases
of the 'OTP tokens' pages (main, 'Settings',
and 'Is managed by').

Assisted-by: Claude noreply@anthropic.com

Summary by Sourcery

Add comprehensive end-to-end coverage for OTP token management, settings, and manager assignment flows, including supporting test helpers for IPA-backed OTP operations and UI interactions.

New Features:

Introduce cucumber feature scenarios for creating, searching, enabling, disabling, and deleting OTP tokens via the main OTP tokens page.
Add cucumber feature scenarios for editing OTP token settings, including description, vendor, refresh, and kebab-menu actions (enable, disable, delete).
Add cucumber feature scenarios for managing OTP token owners and managers via the "Is managed by" tab.

Enhancements:

Extend generic select helper to click inner button elements to support OTP token owner selection in tests.
Enhance custom IPA Cypress command to accept execution options for more flexible failure handling.
Add shared OTP token management step definitions, including seeding, safe deletion, and table interaction helpers used across OTP-related tests.

Tests:

Add new Cypress Cucumber feature files and step definitions covering OTP tokens main page, settings page, and managed-by page end-to-end flows.

sourcery-ai

Hey - I've left some high level feedback:

The OTP feature files repeat a lot of boilerplate setup/cleanup (same users/tokens created and deleted in many scenarios); consider extracting common Given steps into shared step definitions or using Background/Scenario Outlines to reduce duplication and make the flows easier to maintain.
The updated selectOption helper now assumes that every option element contains a button and uses click({ force: true }); if possible, tighten the selector (e.g., a specific data-cy or role) and assert the button exists before clicking, and only fall back to a forced click when the normal click fails or when a flag is passed, to avoid masking real UI issues.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The OTP feature files repeat a lot of boilerplate setup/cleanup (same users/tokens created and deleted in many scenarios); consider extracting common Given steps into shared step definitions or using Background/Scenario Outlines to reduce duplication and make the flows easier to maintain.
- The updated selectOption helper now assumes that every option element contains a button and uses click({ force: true }); if possible, tighten the selector (e.g., a specific data-cy or role) and assert the button exists before clicking, and only fall back to a forced click when the normal click fails or when a flag is passed, to avoid masking real UI issues.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

The tests should cover all the use cases of the 'OTP tokens' pages (main, 'Settings', and 'Is managed by'). Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Carla Martinez <carlmart@redhat.com>

carma12 · 2026-08-12T10:55:59Z

@duzda - I think I amended all the changes mentioned in your feedback.

veronnicka

Hi, I have a few suggestions, please look into them.

veronnicka · 2026-08-14T08:39:18Z

+    Then I should see "otpuser" option in the "modal-select-owner" selector
+
+    When I click on the "modal-button-add" button
+    Then I should not see "add-otp-token-modal" modal


And I should see the token in the table or something along the lines

similar to this
```
And I should see "add-managedby-success" alert

When I search for "otpmanager" in the members table Then I should see "otpmanager" entry in the data table

veronnicka · 2026-08-14T08:40:04Z

+    Then I should see "otpuser" option in the "modal-select-owner" selector
+
+    When I click on the "modal-button-add" button
+    Then I should not see "add-otp-token-modal" modal


And I should see the token in the table

veronnicka · 2026-08-14T08:41:01Z

+    Then I should not see "add-otp-token-modal" modal
+
+  @test
+  Scenario: Delete button is disabled when no token is selected


I dont think this test is needed

and the following two as well

veronnicka · 2026-08-14T08:42:20Z

+    When I click on the "modal-button-ok" button
+    Then I should not see "enable-disable-otp-tokens-modal" modal
+    And I should see "success" alert
+


there should be @cleanup and @seed again between these tests

veronnicka · 2026-08-14T08:43:42Z

+    And I should not see "delete-otp-tokens-modal" modal
+
+  @cleanup
+  Scenario: Cleanup: Delete test data and remaining tokens


nitpick: the name of the cleanup is a bit confusing

veronnicka · 2026-08-14T09:21:49Z

+    And OTP token "settings_token" exists for user "otpsettingsuser" with type "totp" and description "settings_token"
+
+  @test
+  Scenario: Save and Revert buttons are disabled when no changes


I think this test is not necessary

veronnicka · 2026-08-14T09:23:20Z

+
+    When I click on the "otp-tokens-tab-settings-button-save" button
+    Then I should see "success" alert
+    And I should see the "otp-tokens-tab-settings-button-save" button is disabled


should we check for these buttons? if yes, they are missing in the next test. I would suggest to remove the checks for the buttons

veronnicka · 2026-08-14T09:24:00Z

+    And OTP token "settings_token" exists for user "otpsettingsuser" with type "totp" and description "settings_token"
+
+  @test
+  Scenario: Refresh button is available


Either remove this or put it with the test with other buttons

veronnicka · 2026-08-14T09:24:30Z

+    And OTP token "settings_token" exists for user "otpsettingsuser" with type "totp" and description "settings_token"
+
+  @test
+  Scenario: Kebab menu opens and contains actions


is it really testing if it contains actions?

veronnicka · 2026-08-14T09:25:26Z

+
+    When I click on the "modal-button-ok" button
+    Then I should not see "enable-disable-otp-tokens-modal" modal
+    And I should see "success" alert


Im missing a check if its really enabled/disabled.

same for the enable test below

carma12 self-assigned this Aug 7, 2026

carma12 added the needs-review This PR is waiting on a review label Aug 7, 2026

sourcery-ai Bot reviewed Aug 7, 2026

View reviewed changes

carma12 force-pushed the otp-tokens-tests branch from 39cc0d3 to f8d00b9 Compare August 10, 2026 09:53

duzda reviewed Aug 10, 2026

View reviewed changes

Comment thread cypress/e2e/otp_tokens/otp_token_management.ts Outdated

Comment thread cypress/e2e/otp_tokens/otp_token_management.ts Outdated

carma12 force-pushed the otp-tokens-tests branch 2 times, most recently from 5d689e4 to 49e37da Compare August 11, 2026 11:30

Add tests for OTP tokens pages

7931251

The tests should cover all the use cases of the 'OTP tokens' pages (main, 'Settings', and 'Is managed by'). Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Carla Martinez <carlmart@redhat.com>

carma12 force-pushed the otp-tokens-tests branch from 49e37da to 7931251 Compare August 12, 2026 10:55

veronnicka reviewed Aug 14, 2026

View reviewed changes

Uh oh!

Conversation

carma12 commented Aug 7, 2026 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

carma12 commented Aug 12, 2026

Uh oh!

veronnicka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

carma12 commented Aug 7, 2026 •

edited by sourcery-ai Bot

Loading