Repository navigation
utils::sqlite: restore static on test helpers - #328
Merged
Merged
Conversation
stefanb
approved these changes
Oct 10, 2026
Contributor
|
Would you please add “Signed-off-by” to the commit? Thanks! |
157fb89 replaced UTILS_UNUSED with [[maybe_unused]] but dropped `static` from the forward declarations of create_test_table() and verify_test_table(), while their definitions are still static. GCC rejects this ("was declared 'extern' and later 'static'"), so building with --enable-atf fails on Linux. CI only builds with clang, which accepts it. Restore `static` and place the attribute after the declarator, as done elsewhere in 157fb89. Fixes: 157fb89 ("Replace KYUA_ATTRIBUTE_{NORETURN,UNUSED}} ...") Signed-off-by: Daeho Ro <40587651+daeho-ro@users.noreply.github.com>
daeho-ro
force-pushed
the
fix-gcc-build-post-312
branch
from
October 10, 2026 15:52
41222b1 to
b7c9349
Compare
Contributor
|
I'm going to merge the change, but next time -- please use a non-relayed email address. In the event you deleted your GitHub account, we wouldn't be able to get a hold of you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
157fb89 replaced UTILS_UNUSED with [[maybe_unused]] but dropped
staticfrom the forward declarations of create_test_table() and verify_test_table(), while their definitions are still static. GCC rejects this ("was declared 'extern' and later 'static'"), so building with --enable-atf fails on Linux. CI only builds with clang, which accepts it.Restore
staticand place the attribute after the declarator, as done elsewhere in 157fb89.Fixes: 157fb89 ("Replace KYUA_ATTRIBUTE_{NORETURN,UNUSED}} ...")