A build opens with the user's text itself: the extend_prompt wrapper is gone (#1683 review) - #1691
Merged
Conversation
…is gone (#1683 review) With the greenfield flow removed (#1689), `prompts/extend_prompt.md` was a second place where the user prompt got framed — beside the `# User prompt` slot that `prompts/system_prompt.md` already provides for exactly that — and it said nothing the system prompt did not: "in this workspace" is the Workspace section, "existing codebase" is what a project is, and the closing summary it asked for feeds nothing (the PR body comes from the `open-pr` block). A build and a prompt session now open the same way: the text rendered through the system prompt's user-prompt slot (`renderSystemPrompt(...).user`); vanilla, transparent and continuations stay verbatim. `steps.ts` and the prompt file go with their specs; `agent.SPEC.md` also drops the greenfield sections #1689 left behind. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
@brillout reviewed the prompts — I'd drop |
suleimansh
marked this pull request as ready for review
August 24, 2026 15:44
Contributor
|
Sounds good |
Contributor
|
What about the other prompts of: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 automated — follows the prompts review on #1683 (#1347).
What
prompts/extend_prompt.md+ spec,src/steps.ts+ spec + test: deleted.agent.tsopeningPrompt: a build and a prompt session open the same way — the user's text rendered throughsystem_prompt.md's# User promptslot (renderSystemPrompt(...).user). Vanilla, transparent and continuations stay verbatim, as before.agent.SPEC.md: the opening-prompt section rewritten; the two greenfield sections Remove the greenfield flow: a build always extends the existing codebase #1689 left behind ("framed for the workspace it lands in", "produced nothing is pushed once") removed.agent.test.SPEC.md,cli.SPEC.md,prompts/SPEC.md,prompts/README.mdfollow.Why
With greenfield gone, the wrapper was a second place where the user prompt gets framed, beside the slot Rom's own document already provides for exactly that — and it said nothing the system prompt did not: "in this workspace" is the Workspace section, "existing codebase" is what a project is, and the closing summary it asked for feeds nothing (the PR body comes from the
open-prblock). One framing place, and it is the document a person reviews: any "existing codebase" wording that is wanted goes into# User promptinsystem_prompt.md.Verified
pnpm build,typecheck,test: 1580 + 834 green (one fewer test:steps.test.tsis gone).openingPromptfails 7 of the 39 agent tests; reverted, 39/39.Draft on purpose — a prompt change gets its review round before it lands.