feat: add optional You.com search integration - #24
Conversation
- Add YouComProvider implementing IProvider interface - Integration with You.com Search API and MCP server - Support for keyless (100 searches/day) and authenticated modes - Expose search capabilities through youcom-search and youcom-news models - Auto-detection via YDC_API_KEY and YOUCOM_API_KEY environment variables - Comprehensive error handling and health monitoring - Documentation and examples for integration - Test coverage for core functionality The YouCom provider focuses on search and research tools rather than LLM generation, making current web information available to AgentOS agents through You.com's APIs.
|
🧙 Sourcery is reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a YouCom provider with web/news search, health checks, model metadata, runtime autodetection, AgentOS manager wiring, integration tests, a CLI example, documentation, and workspace build configuration. ChangesYouCom provider integration
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant AgentOS
participant AIModelProviderManager
participant YouComProvider
participant YouComSearchAPI
AgentOS->>AIModelProviderManager: initialize youcom provider
AIModelProviderManager->>YouComProvider: initialize configuration
YouComProvider->>YouComSearchAPI: test connectivity
AgentOS->>YouComProvider: search query
YouComProvider->>YouComSearchAPI: request web or news results
YouComSearchAPI-->>YouComProvider: search response
YouComProvider-->>AgentOS: formatted search result
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoAdd optional You.com (YouCom) provider for web/news search tools
AI Description
Diagram
High-Level Assessment
Files changed (7)
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d43387975
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| { envKey: 'YDC_API_KEY', provider: 'youcom' }, | ||
| { envKey: 'YOUCOM_API_KEY', provider: 'youcom' }, // Fallback for legacy env var |
There was a problem hiding this comment.
When agent() or generateText() is used with the documented YDC_API_KEY/YOUCOM_API_KEY environment setup, these probes select youcom, but resolveProvider() has neither variable in ENV_KEY_MAP and does not list You.com in KEYLESS_PROVIDER_IDS (src/api/model.ts:40-62). It therefore throws at src/api/model.ts:158-160 before YouComProvider.initialize() can read the key; keyless calls with an explicit provider: 'youcom' fail at the same point. Add the credential mappings and keyless handling to the high-level resolver.
Useful? React with 👍 / 👎.
| // For now, YouComProvider focuses on tool integration rather than LLM generation | ||
| // This could be enhanced to provide search-augmented responses | ||
| return { | ||
| id: `youcom-${Date.now()}`, | ||
| object: 'chat.completion', | ||
| created: Math.floor(Date.now() / 1000), | ||
| modelId: modelId, | ||
| choices: [{ | ||
| index: 0, | ||
| message: { | ||
| role: 'assistant', | ||
| content: 'YouComProvider is optimized for search and research tools. Please use the search() method or integrate with AgentOS tools for web search capabilities.', | ||
| }, |
There was a problem hiding this comment.
When a caller bypasses credential resolution with an explicit key and uses the documented agent({ provider: 'youcom' }).session().send(...) flow, generateText() invokes this method, which ignores the prompt and returns the same canned message without calling search(). The advertised tools: ['search'] does not bridge the gap either: the provider registers no ITool, and adaptTools() discards string arrays. Consequently the primary agent integration never performs a search; expose an executable search tool or implement search-backed/fallback completion behavior instead of reporting a successful completion.
Useful? React with 👍 / 👎.
| const { count = 10, type = 'web' } = options; | ||
|
|
||
| try { | ||
| const url = new URL(this.config.searchApiUrl!); | ||
| url.searchParams.set('query', query); | ||
| url.searchParams.set('count', count.toString()); |
There was a problem hiding this comment.
For calls such as the documented search(query, { type: 'news' }), type is destructured but never added to the request or used to transform the response, so the wire request is identical to the default web search. This makes the news option—and effectively the advertised youcom-news capability—unable to select news results; forward the type through the API's supported parameter/endpoint or implement the corresponding filtering.
Useful? React with 👍 / 👎.
| public async checkHealth(): Promise<{ isHealthy: boolean; details?: unknown }> { | ||
| try { | ||
| await this.testSearchConnectivity(); | ||
| return { isHealthy: true, details: { apiKeyConfigured: Boolean(this.config.apiKey) } }; | ||
| } catch (error) { |
There was a problem hiding this comment.
When the endpoint is unreachable or responds with an error such as 401 or 500, testSearchConnectivity() catches and suppresses that failure, so this try always reaches the isHealthy: true return and the unhealthy branch is unreachable. Monitoring will therefore report a broken provider as healthy; use a non-swallowing connectivity probe for checkHealth() while retaining best-effort behavior only during initialization.
Useful? React with 👍 / 👎.
Code Review by Qodo
1.
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 12
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/providers/youcom-provider.md`:
- Around line 73-80: Update the Direct Search API example to import
YouComProvider from its public package path and use keyless initialization by
omitting apiKey, or conditionally reading process.env.YDC_API_KEY without
passing the literal string "optional".
- Around line 55-63: Fix both examples in the youcom provider documentation by
eliminating the self-shadowing `const agent = agent(...)` declaration. Rename
the local instance variable or alias the imported `agent` factory, and apply the
same correction to the additional snippet while preserving the existing
configuration and usage.
- Around line 20-28: Update the quick-start example around the researcher agent
and session.send call to configure a text-generation-capable fallback LLM
alongside the YouCom provider, or replace the completion-style prompt with an
explicit YouCom search/tool invocation. Ensure the copy-paste example can
execute successfully while preserving the current research-assistant intent.
- Around line 7-11: Update the introductory capability list in the YouCom
provider documentation to describe only the currently exposed youcom-search and
youcom-news functionality. Move the content extraction and research synthesis
bullets to the MCP section, or clearly label them as planned future MCP tools.
In `@pnpm-workspace.yaml`:
- Around line 1-13: Replace every placeholder value under allowBuilds with an
audited boolean approval decision, using true or false for each listed package.
Preserve the existing package keys and ensure no placeholder text remains.
In `@src/api/runtime/provider-defaults.ts`:
- Around line 138-139: Update the youcom probe construction and
PROBE_BY_PROVIDER handling in the provider defaults so a custom priority
containing youcom retains both YDC_API_KEY and YOUCOM_API_KEY probes, checking
the primary variable as well as the legacy fallback. Ensure deduplication does
not discard the YDC_API_KEY entry when retaining the last youcom probe.
In `@src/core/llm/providers/implementations/YouComProvider.ts`:
- Around line 154-165: Update the `YouComProvider.search` method to apply the
destructured `type` value when constructing the request and handling its
response, so `type: 'news'` uses the news-specific behavior while `type: 'web'`
preserves the existing web search behavior. Ensure the advertised `youcom-news`
capability routes through this implemented news path.
- Around line 116-131: Update testSearchConnectivity and its callers so failed
HTTP responses or network errors produce an unsuccessful health result instead
of being treated as healthy. Preserve offline-tolerant initialization by
explicitly ignoring or handling the failure only during initialization, while
checkHealth propagates or consumes the probe status and returns isHealthy:
false.
- Around line 189-218: The YouComProvider.generateCompletion method must reject
unsupported text generation instead of returning boilerplate content and
fabricated usage; throw the established unsupported-operation error until real
fallback delegation exists. In
src/core/llm/providers/implementations/YouComProvider.ts lines 189-218, replace
the hard-coded completion response; in src/api/runtime/provider-defaults.ts
lines 101-104, remove text/cheap defaults unless backed by a real completion
provider; in tests/youcom-integration.test.ts lines 88-99, assert the
unsupported-operation error; and in examples/youcom-search-example.mjs lines
23-31, demonstrate direct search or configure a real completion provider.
- Around line 52-64: Update YouComProvider’s searchApiUrl default and request
authentication to use the documented https://ydc-index.io/v1/search endpoint
with X-API-Key instead of bearer auth. In search(), normalize authenticated
responses from data.results into YouComSearchResult, and update that interface’s
web/news fields to represent description and snippets while preserving title,
url, and published_at where applicable.
In `@tests/youcom-integration.test.ts`:
- Around line 102-109: Replace the literal self-comparison in the “should be
discoverable in provider registry” test with an actual AIModelProviderManager
integration. Initialize the manager using an enabled youcom provider
configuration, then call getProvider('youcom') and assert that the provider is
returned.
- Around line 39-59: Replace the broad catch in “should perform basic search
functionality” with a mocked fetch-based test that asserts the request endpoint,
parameters, and normalized search response. Remove unconditional success on
search errors; only skip explicitly recognized network or quota failures, while
propagating authentication, endpoint, parsing, and parameter errors.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: adebb081-6aea-4a56-85cf-ca76cc47d8e6
📒 Files selected for processing (7)
docs/providers/youcom-provider.mdexamples/youcom-search-example.mjspnpm-workspace.yamlsrc/api/runtime/provider-defaults.tssrc/core/llm/providers/AIModelProviderManager.tssrc/core/llm/providers/implementations/YouComProvider.tstests/youcom-integration.test.ts
| public async generateCompletion( | ||
| modelId: string, | ||
| messages: ChatMessage[], | ||
| options: ModelCompletionOptions | ||
| ): Promise<ModelCompletionResponse> { | ||
| if (!this._isInitialized) { | ||
| throw new Error('YouComProvider is not initialized. Call initialize() first.'); | ||
| } | ||
|
|
||
| // For now, YouComProvider focuses on tool integration rather than LLM generation | ||
| // This could be enhanced to provide search-augmented responses | ||
| return { | ||
| id: `youcom-${Date.now()}`, | ||
| object: 'chat.completion', | ||
| created: Math.floor(Date.now() / 1000), | ||
| modelId: modelId, | ||
| choices: [{ | ||
| index: 0, | ||
| message: { | ||
| role: 'assistant', | ||
| content: 'YouComProvider is optimized for search and research tools. Please use the search() method or integrate with AgentOS tools for web search capabilities.', | ||
| }, | ||
| finishReason: 'stop' | ||
| }], | ||
| usage: { | ||
| totalTokens: 50, | ||
| promptTokens: 25, | ||
| completionTokens: 25 | ||
| } | ||
| }; |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift
Do not route text generation to a provider that returns boilerplate.
YouComProvider.generateCompletion() returns a successful hard-coded response and invented token usage, while runtime defaults route text requests to it. Consequently, auto-detected and example session.send() requests return boilerplate rather than search-backed output or an explicit unsupported-operation error.
src/core/llm/providers/implementations/YouComProvider.ts#L189-L218: reject completions as unsupported until real fallback delegation is implemented; do not fabricate a successful completion.src/api/runtime/provider-defaults.ts#L101-L104: remove text/cheap defaults, or register them only when an actual fallback completion provider is wired.tests/youcom-integration.test.ts#L88-L99: assert the intended unsupported-operation error rather than the placeholder response.examples/youcom-search-example.mjs#L23-L31: demonstrate direct search or configure a real completion provider alongside the search integration.
📍 Affects 4 files
src/core/llm/providers/implementations/YouComProvider.ts#L189-L218(this comment)src/api/runtime/provider-defaults.ts#L101-L104tests/youcom-integration.test.ts#L88-L99examples/youcom-search-example.mjs#L23-L31
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/core/llm/providers/implementations/YouComProvider.ts` around lines 189 -
218, The YouComProvider.generateCompletion method must reject unsupported text
generation instead of returning boilerplate content and fabricated usage; throw
the established unsupported-operation error until real fallback delegation
exists. In src/core/llm/providers/implementations/YouComProvider.ts lines
189-218, replace the hard-coded completion response; in
src/api/runtime/provider-defaults.ts lines 101-104, remove text/cheap defaults
unless backed by a real completion provider; in tests/youcom-integration.test.ts
lines 88-99, assert the unsupported-operation error; and in
examples/youcom-search-example.mjs lines 23-31, demonstrate direct search or
configure a real completion provider.
- Replace placeholder values in pnpm-workspace.yaml with proper boolean configuration - Add youcom to ENV_KEY_MAP for proper environment key resolution - Add youcom to KEYLESS_PROVIDER_IDS to support keyless operation - Remove youcom from PROVIDER_DEFAULTS text models since it's search-only - Fix generateCompletion to throw error instead of returning static response - Fix generateCompletionStream to yield proper error response instead of throwing - Fix search method to actually use the 'type' parameter for news vs web search This addresses the main issues raised by CodeRabbit and other reviewers: - Broken pnpm workspace configuration - Auto-detection failure due to missing ENV_KEY mapping - Incorrect completion behavior for search-only provider - Search type parameter being ignored
|
Good catch on the key issues raised by the automated reviews! I've addressed the main problems: Fixed pnpm-workspace.yaml:
Fixed YouCom auto-detection:
Fixed provider behavior:
These changes align the implementation with the intended design: YouComProvider as a search tool provider, not a text completion provider. The provider registry and auto-detection should now work properly while making it clear that this provider is for search capabilities. |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (4)
src/core/llm/providers/implementations/YouComProvider.ts (4)
181-182: 🎯 Functional Correctness | 🟠 MajorNormalize the API response before returning it.
This remains the previously reported contract issue:
return dataexposes the raw{ results, metadata }envelope asYouComSearchResultwithout validation or normalization. Ensure the declared type matches the documentedresults.web/results.newsentries, includingdescriptionandsnippets, and add coverage for both result sections. (you.com)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/core/llm/providers/implementations/YouComProvider.ts` around lines 181 - 182, Update the response handling in YouComProvider so the parsed API envelope is validated and normalized into the declared YouComSearchResult shape before returning, rather than returning raw data. Ensure results.web and results.news entries include the documented description and snippets fields, and add coverage for both sections.
87-87: 🎯 Functional Correctness | 🟠 MajorAlign the endpoint and authentication with You.com’s Search API contract.
This remains the previously reported mismatch: Line 87 uses
api.you.com/v1/agents/search, while Lines 144-146 sendAuthorization: Bearer. The current Search API documentsGET /v1/searchwithX-API-Key; authenticated requests will fail unless this integration is updated or the custom endpoint is explicitly supported separately. (you.com)Also applies to: 144-146
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/core/llm/providers/implementations/YouComProvider.ts` at line 87, Update YouComProvider’s searchApiUrl to the documented GET /v1/search endpoint and change the request authentication from Authorization: Bearer to the X-API-Key header, ensuring the configured API key is sent under that header consistently.
118-121: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winAdd timeouts to the You.com outbound fetches.
initialize()andsearch()both callfetch()directly, so slow/unreachable You.com API traffic can leave startup, health checks, or user searches stalled. Use bounded timeout signals for both requests at lines 117-169 and keep the existing network-error handling in the catch blocks.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/core/llm/providers/implementations/YouComProvider.ts` around lines 118 - 121, Update the outbound fetch calls in YouComProvider.initialize() and search() to use bounded timeout signals, including the existing fetch at the initialization health check and the search request. Preserve the current request behavior and network-error handling in their catch blocks while ensuring both requests abort when their timeout expires.
159-164: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winReject invalid
countvalues before building the You.com request.The Search API uses 10 as the default when
countis omitted; accept only an explicit integer in a supported range and throw beforeurl.searchParams.set('count', ...).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/core/llm/providers/implementations/YouComProvider.ts` around lines 159 - 164, Validate the explicit count value in the YouComProvider request flow before constructing the URL or calling url.searchParams.set('count', ...). Preserve 10 only when count is omitted, and otherwise require an integer within the Search API’s supported range, throwing for invalid values.
♻️ Duplicate comments (2)
src/core/llm/providers/implementations/YouComProvider.ts (2)
165-167: 🎯 Functional Correctness | 🟠 MajorDo not rely on the undocumented
type=newsparameter.This is similar to the previous search-type finding, but the current public API contract does not list
typeas a query parameter. The API returns unified web/news results based on query intent; news workflows use supported controls such asfreshness, then consumeresults.news. As written,youcom-newsis not guaranteed to perform news-specific searches. (you.com)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/core/llm/providers/implementations/YouComProvider.ts` around lines 165 - 167, Remove the undocumented type=news query parameter handling from the search URL construction in YouComProvider. Preserve supported controls such as freshness for news requests and continue consuming news results through the existing results.news workflow.
116-131: 🎯 Functional Correctness | 🟠 MajorMake health checks report failed probes.
This remains unresolved:
testSearchConnectivity()catches failures and returns normally, socheckHealth()always returnsisHealthy: true. Preserve offline-tolerant initialization if required, but return the probe result as unhealthy fromcheckHealth().Also applies to: 284-287
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/core/llm/providers/implementations/YouComProvider.ts` around lines 116 - 131, Update YouComProvider.testSearchConnectivity and its checkHealth caller so probe failures are reported as unhealthy instead of being swallowed as successful completion. Preserve the current non-throwing behavior during initialization, but return or propagate an explicit success/failure result from testSearchConnectivity and use it to set checkHealth’s isHealthy value.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/core/llm/providers/implementations/YouComProvider.ts`:
- Around line 181-182: Update the response handling in YouComProvider so the
parsed API envelope is validated and normalized into the declared
YouComSearchResult shape before returning, rather than returning raw data.
Ensure results.web and results.news entries include the documented description
and snippets fields, and add coverage for both sections.
- Line 87: Update YouComProvider’s searchApiUrl to the documented GET /v1/search
endpoint and change the request authentication from Authorization: Bearer to the
X-API-Key header, ensuring the configured API key is sent under that header
consistently.
- Around line 118-121: Update the outbound fetch calls in
YouComProvider.initialize() and search() to use bounded timeout signals,
including the existing fetch at the initialization health check and the search
request. Preserve the current request behavior and network-error handling in
their catch blocks while ensuring both requests abort when their timeout
expires.
- Around line 159-164: Validate the explicit count value in the YouComProvider
request flow before constructing the URL or calling
url.searchParams.set('count', ...). Preserve 10 only when count is omitted, and
otherwise require an integer within the Search API’s supported range, throwing
for invalid values.
---
Duplicate comments:
In `@src/core/llm/providers/implementations/YouComProvider.ts`:
- Around line 165-167: Remove the undocumented type=news query parameter
handling from the search URL construction in YouComProvider. Preserve supported
controls such as freshness for news requests and continue consuming news results
through the existing results.news workflow.
- Around line 116-131: Update YouComProvider.testSearchConnectivity and its
checkHealth caller so probe failures are reported as unhealthy instead of being
swallowed as successful completion. Preserve the current non-throwing behavior
during initialization, but return or propagate an explicit success/failure
result from testSearchConnectivity and use it to set checkHealth’s isHealthy
value.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 7cef24e2-27e4-4116-8441-99ac54388622
📒 Files selected for processing (4)
pnpm-workspace.yamlsrc/api/model.tssrc/api/runtime/provider-defaults.tssrc/core/llm/providers/implementations/YouComProvider.ts
💤 Files with no reviewable changes (1)
- src/api/runtime/provider-defaults.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- pnpm-workspace.yaml
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/youcom-integration.test.ts (1)
27-38: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winStub
YDC_API_KEY/YOUCOM_API_KEYto avoid host-environment leakage.Several tests call
provider.initialize({})with no explicitapiKeyand then assert unauthenticated behavior (e.g.apiKeyConfigured: falseat Line 154, noX-API-Keyheader expectations).YouComProvider.initializeauto-detects the key fromprocess.env.YDC_API_KEY || process.env.YOUCOM_API_KEY. Since this PR introduces these exact env vars as first-class provider-detection keys (seeprovider-defaults.ts), any CI runner or local shell that happens to export them will silently flip these tests into authenticated mode and break the assertions.🧪 Suggested fix: isolate env in beforeEach/afterEach
beforeEach(() => { provider = new YouComProvider(); fetchMock = vi.fn(); vi.stubGlobal('fetch', fetchMock); + vi.stubEnv('YDC_API_KEY', ''); + vi.stubEnv('YOUCOM_API_KEY', ''); }); afterEach(async () => { if (provider.isInitialized) { await provider.shutdown(); } vi.unstubAllGlobals(); + vi.unstubAllEnvs(); });Also applies to: 40-166
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/youcom-integration.test.ts` around lines 27 - 38, Isolate the YouCom integration tests from host authentication settings by stubbing YDC_API_KEY and YOUCOM_API_KEY to an absent value in beforeEach and restoring the original environment in afterEach. Update the setup around provider initialization so tests calling YouComProvider.initialize({}) consistently exercise unauthenticated behavior while preserving environment cleanup.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/youcom-integration.test.ts`:
- Around line 27-38: Isolate the YouCom integration tests from host
authentication settings by stubbing YDC_API_KEY and YOUCOM_API_KEY to an absent
value in beforeEach and restoring the original environment in afterEach. Update
the setup around provider initialization so tests calling
YouComProvider.initialize({}) consistently exercise unauthenticated behavior
while preserving environment cleanup.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 560c7aa5-3cfd-43b0-81c9-d79d8b4d8c50
📒 Files selected for processing (6)
docs/providers/youcom-provider.mdexamples/youcom-search-example.mjssrc/api/runtime/provider-defaults.tssrc/core/llm/providers/implementations/YouComProvider.tssrc/index.tstests/youcom-integration.test.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- docs/providers/youcom-provider.md
- src/core/llm/providers/implementations/YouComProvider.ts
Stub YDC_API_KEY and YOUCOM_API_KEY to ensure tests consistently exercise unauthenticated behavior without interference from host environment settings.
|
Fixed the environment isolation issue in tests. Added proper stubbing of This addresses the test reliability concern where CI runners or local environments with these keys would break test assertions. |
|
Follow-up fixes are in on
This keeps YouCom keyless by default in the quick start/example and isolates the tests from host |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/api/runtime/__tests__/provider-defaults.test.ts`:
- Around line 130-145: Revise the autoDetectProvider tests around the “detects
youcom from YDC_API_KEY” case to separate YDC-only and YOUCOM_API_KEY-only
detection scenarios, removing the ambiguity caused by setting both variables. If
YDC_API_KEY precedence is part of the contract, add a separate assertion against
the resolved credential rather than inferring precedence from the provider
result.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 3d184b2a-50d8-417b-9da0-63077766bb14
📒 Files selected for processing (3)
docs/providers/youcom-provider.mdexamples/youcom-search-example.mjssrc/api/runtime/__tests__/provider-defaults.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/providers/youcom-provider.md
| it('detects youcom from YDC_API_KEY before the legacy fallback', () => { | ||
| delete process.env.OPENAI_API_KEY; | ||
| delete process.env.OPENROUTER_API_KEY; | ||
| delete process.env.ANTHROPIC_API_KEY; | ||
| delete process.env.GEMINI_API_KEY; | ||
| delete process.env.GROQ_API_KEY; | ||
| delete process.env.TOGETHER_API_KEY; | ||
| delete process.env.MISTRAL_API_KEY; | ||
| delete process.env.XAI_API_KEY; | ||
| delete process.env.OLLAMA_BASE_URL; | ||
| delete process.env.STABILITY_API_KEY; | ||
| delete process.env.REPLICATE_API_TOKEN; | ||
| process.env.YDC_API_KEY = 'new-key'; | ||
| process.env.YOUCOM_API_KEY = 'legacy-key'; | ||
|
|
||
| expect(autoDetectProvider()).toBe('youcom'); |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
This assertion does not verify key precedence.
With both environment variables set, autoDetectProvider() returns youcom regardless of probe order. Split this into YDC-only and legacy-only detection tests, and assert the resolved credential separately if YDC_API_KEY precedence is part of the contract.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/api/runtime/__tests__/provider-defaults.test.ts` around lines 130 - 145,
Revise the autoDetectProvider tests around the “detects youcom from YDC_API_KEY”
case to separate YDC-only and YOUCOM_API_KEY-only detection scenarios, removing
the ambiguity caused by setting both variables. If YDC_API_KEY precedence is
part of the contract, add a separate assertion against the resolved credential
rather than inferring precedence from the provider result.
1 participant
Summary
This PR adds You.com as an optional search provider to AgentOS, enabling agents to access real-time web search and research capabilities through You.com's APIs.
Changes
Key Features
youcom-searchfor web search,youcom-newsfor news searchUsage Example
Integration Approach
YouCom follows AgentOS provider patterns but focuses on search capabilities rather than text generation. This allows agents to augment LLM responses with current web information while maintaining compatibility with existing provider systems.
Environment Variables
YDC_API_KEY: Optional You.com API key (recommended for production)YOUCOM_API_KEY: Legacy fallback environment variableTesting
examples/youcom-search-example.mjsThis integration provides AgentOS agents with access to real-time web information while maintaining the framework's provider-agnostic architecture. The keyless tier enables immediate evaluation, while API key authentication unlocks higher quotas for production use.
Summary by Sourcery
Integrate You.com as an optional search-focused provider within AgentOS, including model registration, auto-detection, documentation, examples, and tests.
New Features:
Enhancements:
Build:
Documentation:
Tests:
Summary by CodeRabbit
YouComProviderfrom the main package.