refactor: fix icon registry, installer bugs, and versioning; disable … - #1
Merged
Merged
Conversation
…exec time by default
- Route plugin icons through the shared AP_ICONS registry. All first-party
plugins referenced nonexistent _AP_ICO_* shortcut vars or hardcoded
nerd-font glyphs, so they never respected the ASCII/Unicode/Font
Awesome/Nerd Font tier switching the core segments already honored.
Added the missing icon keys (CPANEL, GH, TARGET, VPN_ON/OFF, TAILSCALE,
CPU, RAM) to all four tiers, and replaced 12 icons that were pulled from
Material Design Icons (a visibly larger/bolder glyph set) with
same-family Font Awesome/Devicons equivalents for consistent sizing.
- Consolidate the git segment into a single `git status --porcelain=v2
--branch` call, replacing the rev-parse + symbolic-ref + status +
rev-list combo (4-5 forks per prompt refresh).
- Fix icon-tier and installer quoting bugs:
- AP_USE_NERD_FONT/AP_ASCII_FALLBACK had no default, so fresh installs
silently fell back to the Unicode tier instead of Nerd Font.
- install.sh wrote \" (literal backslash-quote) into ~/.zshrc's
HISTFILE line and into the bash->zsh bridge condition in ~/.bashrc,
permanently breaking the bridge's -z check.
- The bridge only patched ~/.bashrc; added the same bridge to
~/.profile since fresh login shells often don't chain into .bashrc.
- Introduce a single-source-of-truth VERSION file. Add
scripts/bump-version.sh to sync APORIA_VERSION across aporia.zsh-theme
and install.sh, plus CI/release checks that fail if any copy drifts
from the tagged version. `aporia upgrade` now reports the actual
before/after version instead of upgrading silently.
- Disable the exec-time segment by default (AP_SHOW_EXEC_TIME=0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…exec time by default
Route plugin icons through the shared AP_ICONS registry. All first-party plugins referenced nonexistent AP_ICO* shortcut vars or hardcoded nerd-font glyphs, so they never respected the ASCII/Unicode/Font Awesome/Nerd Font tier switching the core segments already honored. Added the missing icon keys (CPANEL, GH, TARGET, VPN_ON/OFF, TAILSCALE, CPU, RAM) to all four tiers, and replaced 12 icons that were pulled from Material Design Icons (a visibly larger/bolder glyph set) with same-family Font Awesome/Devicons equivalents for consistent sizing.
Consolidate the git segment into a single
git status --porcelain=v2 --branchcall, replacing the rev-parse + symbolic-ref + status + rev-list combo (4-5 forks per prompt refresh).Fix icon-tier and installer quoting bugs:
Introduce a single-source-of-truth VERSION file. Add scripts/bump-version.sh to sync APORIA_VERSION across aporia.zsh-theme and install.sh, plus CI/release checks that fail if any copy drifts from the tagged version.
aporia upgradenow reports the actual before/after version instead of upgrading silently.Disable the exec-time segment by default (AP_SHOW_EXEC_TIME=0).