Skip to content

fix: serialize mkdir shell fork on the run_command lock #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krystophny wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: serialize mkdir shell fork on the run_command lock #1298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/fpm_backend.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,11 +327,14 @@ subroutine build_target(model,target,verbose,dry_run,table,stat)

integer :: fh

!$omp critical
! mkdir shells out (is_dir 'test -d' and 'mkdir -p'), which forks. Serialize
! it on the same run_command lock as every other shell fork so it cannot run
! concurrently with a link/archive/compile shell fallback on another thread.
!$omp critical (run_command)
if (.not.exists(dirname(target%output_file)) .and. .not.dry_run) then
call mkdir(dirname(target%output_file),verbose)
end if
!$omp end critical
!$omp end critical (run_command)

select case(target%target_type)

Expand Down
Loading