Skip to content

Cut devtools_shared 13.1.0 with new FileSystemExtension API from 14.0.0#9895

Merged
srawlins merged 3 commits into
flutter:shared-13-0-2from
srawlins:api-13-0-2
Jul 15, 2026
Merged

Cut devtools_shared 13.1.0 with new FileSystemExtension API from 14.0.0#9895
srawlins merged 3 commits into
flutter:shared-13-0-2from
srawlins:api-13-0-2

Conversation

@srawlins

Copy link
Copy Markdown
Contributor

This creates a backpatch in the devtools_shared 13.x.x line, providing the new FileSystemExtension API from devtools_shared 14.0.0, without removing the old LocalFileSystem API.

The old LocalFileSystem API is deprecated in this release.

The new FileSystemExtension API comes directly from 34f9380, released in devtools_shared 14.0.0. The only divergence is in import prefixes, to prevent collisions.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new FileSystemExtension on file.FileSystem to replace the deprecated LocalFileSystem extension APIs, allowing the file system to be mocked in tests. It also adds a dependency on the file package and bumps the package version to 13.1.0. The review feedback highlights several compilation errors in the deprecated LocalFileSystem extension due to the new scoped import of dart:io (specifically, missing prefixes for io.File and io.Directory, and a missing Directory import). Additionally, it is recommended to use recursive: true when creating the DevTools directory to prevent potential exceptions in clean environments.

Comment thread packages/devtools_shared/lib/src/server/file_system.dart Outdated
Comment thread packages/devtools_shared/lib/src/server/file_system.dart Outdated
Comment thread packages/devtools_shared/lib/src/server/file_system.dart
Comment thread packages/devtools_shared/lib/src/server/file_system.dart
Comment thread packages/devtools_shared/lib/src/server/file_system.dart
Comment thread packages/devtools_shared/lib/src/server/file_system.dart
@srawlins srawlins merged commit 26b579f into flutter:shared-13-0-2 Jul 15, 2026
85 of 88 checks passed
@srawlins srawlins deleted the api-13-0-2 branch July 15, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants