Skip to content

Prevent GC of value during async eval #9885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srawlins merged 5 commits into from
Jul 16, 2026
+22 −3
Merged

Prevent GC of value during async eval #9885

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d7f8265
Prevent GC of value during async eval
srawlins Jul 9, 2026
ba981d3
fix
srawlins Jul 11, 2026
c0b3c8f
note
srawlins Jul 13, 2026
24bd17c
while-loop
srawlins Jul 13, 2026
d0c4d6e
changelog
srawlins Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/devtools_app_shared/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ found in the LICENSE file or at https://developers.google.com/open-source/licens
## 0.5.2-wip
* Fix a `RangeError` thrown by `SplitPane` when the number of children
changes between rebuilds.
* Fix garbage collection issues with the result list in `asyncEval` on both native VM and web.
* The minimum Dart SDK version is bumped to 3.11.0.
* The minimum Flutter SDK version is bumped to 3.41.0.

Expand Down
15 changes: 15 additions & 0 deletions packages/devtools_app_shared/lib/src/service/eval_on_dart_library.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,20 @@ class EvalOnDartLibrary extends DisposableController
await safeEval(
'() async {'
' final reader = widgetInspectorService.toObject("$readerId", "$readerGroup") as List;'
' // Keep a strong reference to `reader` in the target app to prevent it'
' // from being garbage collected by Chrome/VM before the future resolves.'
' // Without this, the reader is only weakly referenced by the inspector'
' // service and is aggressively GCed, causing a TypeError/TimeoutException'
' // or failing the assertion that the retrieved result length is 1 or 2.'
' bool isDone = false;'
' int ticks = 0;'
' Timer.periodic(const Duration(milliseconds: 50), (timer) {'
' final _ = reader;'
' // Stop pinning after a 5-second buffer when the future has completed.'
' if (isDone && ++ticks > 100) {'
Comment thread
srawlins marked this conversation as resolved.
Outdated
' timer.cancel();'
' }'
' });'
Comment thread
srawlins marked this conversation as resolved.
Outdated
' try {'
// Cast as dynamic so that it is possible to await Future<void>
' dynamic result = ($expression) as dynamic;'
Expand All @@ -437,6 +451,7 @@ class EvalOnDartLibrary extends DisposableController
' reader.add(err);'
' reader.add(stack);'
' } finally {'
' isDone = true;'
' postEvent("future_completed", {"future_id": $futureId, "client_id": $_clientId});'
' }'
'}()',
Expand Down
Loading