DOCS: Note the differing nonce_verify default on draft endpoints - #17
Open
dhrupo wants to merge 1 commit into
Open
DOCS: Note the differing nonce_verify default on draft endpoints#17dhrupo wants to merge 1 commit into
dhrupo wants to merge 1 commit into
Conversation
fluentform/nonce_verify defaults to off for submission but on for the Save & Continue endpoints. The page documented only the submission default, so a site owner working around full-page caching had no way to know the draft endpoints behave differently. Refs: https://lounge.authlab.io/projects#/boards/16/tasks/22244-DraftSubmissionsManager%3A%3Averif
Deploying fluentform-developers with
|
| Latest commit: |
5bf992d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://35e221b2.fluentform-developers.pages.dev |
| Branch Preview URL: | https://docs-nonce-verify-endpoint-d.fluentform-developers.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fluentform/nonce_verifydefaults to off for form submission but on for the Save & Continue (draft/partial entry) endpoints. The page documented only the submission default and scoped the filter toFormValidationService->validateNonce(), so a site owner working around full-page caching had no way to learn the draft endpoints behave differently — or that opting out there also disables the nonce on the resume-link email endpoint.Related issue: Refs: https://lounge.authlab.io/projects#/boards/16/tasks/22244-DraftSubmissionsManager%3A%3Averif
Cross-repo PRs: fix: https://github.com/fluentform/fluentformpro/pull/256 (pro) · tests: https://github.com/fluentform/fluentform-dev/pull/1123
Changes
Adds a "Defaults differ by endpoint" section to the
fluentform/nonce_verifyblock insrc/hooks/filters/miscellaneous.md:falseis explicitHow to verify
npm run dev(or the project's usual preview command).fluentform/nonce_verify.Anything the reviewer should know?
This documents behaviour introduced by the matching Pro PR — it should not land before that one, or it will describe a default the code does not yet have.
Depends on Pro's decision that the draft default stays
true. If that PR ends up flipping tofalsefor parity with submission, this page needs a corresponding edit.