Skip to content

feat: support tpl evaluation in podAnnotations #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elimayost wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support tpl evaluation in podAnnotations #709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/fluentd/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

### Added

- Support `tpl` evaluation in `podAnnotations` to allow dynamic checksums from parent charts. ([#709](https://github.com/fluent/helm-charts/pull/709)) @elimayost
- Add `variantVersion` value to specify the version of the variant to use. ([#720](https://github.com/fluent/helm-charts/pull/720)) @stevehipwell

### Changed
Expand Down
4 changes: 2 additions & 2 deletions charts/fluentd/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ spec:
metadata:
annotations:
checksum/config: {{ include (print $.Template.BasePath "/fluentd-configurations-cm.yaml") . | sha256sum }}
{{- with .Values.podAnnotations }}
{{- toYaml . | nindent 8 }}
{{- range $k, $v := .Values.podAnnotations }}
{{ printf "%s: %s" $k ((tpl $v $) | quote) }}
{{- end }}
labels:
{{- include "fluentd.selectorLabels" . | nindent 8 }}
Expand Down
2 changes: 1 addition & 1 deletion charts/fluentd/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ annotations: {}
##
labels: {}

## Annotations to be added to fluentd pods
## Annotations to be added to fluentd pods. Supports tpl evaluation.
##
podAnnotations: {}

Expand Down
Loading