Add pdb to fluentd helm chart#445
Conversation
Signed-off-by: i502474 <johnny.hanbo@gmail.com>
|
Would be great to have this merged in 🙏 |
|
Any update on this? |
|
Also we are looking for PodDisruptionBudgets in fluentd. All other tools used by us (fluent-bit, argocd, prometheus, sealed-secrets, etc.) provide support for PodDisruptionBudgets. Please merge already existing PR into master. |
|
To ensure our fluentd workloads remain available during cluster maintenance, we want to configure PDB for it. We use a toolset (ingress-nginx controller and more) which allows us to configure and use PDBs for all applications except fluentd. We would be very grateful if this PR could be merged in not too far future. Thanks in advance. |
|
Please can you rebase on the latest versions and resolve any conflicts so we can bring in the updated CI? |
Signed-off-by: jhanbo <johnny.hanbo@gmail.com>
|
Is this a duplicate of #446? |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
stevehipwell
left a comment
There was a problem hiding this comment.
Would this not be better as an opt in feature rather than having a default and no way of disabling it? You're also missing a CHANGELOG entry.
Hi,
Adding PodDisruptionBudget to fluentd helm chart in case of Deployment or StatefulSet
Thanks,
Johnny