in_sql: fix all_tables crash by passing a Config::Element to TableElement#configure#178
Merged
Merged
Conversation
…ment#configure all_tables built each discovered table by passing a plain Hash to TableElement#configure, but Fluent::Configurable#configure expects a Fluent::Config::Element and calls #corresponding_proxies on it, so every discovered table raised NoMethodError and #start failed. Wrap the attributes in a Fluent::Config::Element. update_column defaults to nil, so it no longer needs to be passed explicitly. Fixes fluent#177 Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
kenhys
requested changes
Jul 10, 2026
Co-authored-by: Kentaro Hayashi <kenhys@gmail.com> Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
fix/all-tables-config-element
branch
from
346e9d1 to
5c88dee
Compare
kenhys
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all_tablesbuilt each discovered table by passing a plain Hash toTableElement#configure,but
Fluent::Configurable#configureexpects aFluent::Config::Elementand calls#corresponding_proxieson it,so every discovered table raised
NoMethodErrorand#startfailed.Wrap the attributes in a
Fluent::Config::Element.update_columndefaults tonil, so it no longer needs to be passed explicitly.Fixes #177