skills: Extract skills from memory#12068
Conversation
📝 WalkthroughWalkthroughThis PR updates AGENTS.md with Windows-specific runtime test skipping guidance, bundled library edit restrictions, and commit lint clarifications. It also adds a new skills/ directory containing an index README and a comprehensive Fluent Bit skill bundle with documentation covering testing, patch workflow, pipeline architecture, and subsystem patterns. ChangesAGENTS.md Windows and Contribution Guidance
Estimated code review effort: 2 (Simple) | ~10 minutes New Fluent Bit Skills Documentation
Estimated code review effort: 1 (Trivial) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 692c24a2df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
692c24a to
c0c82cb
Compare
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
077ecd7 to
11625e0
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
skills/fluent-bit/testing.md (1)
42-49: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winPrefer
run_tests.pyas the primary integration example.The raw
pytestinvocation bypasses the repo's integration wrapper, which already handles--valgrind,--valgrind-strict,FLUENT_BIT_BINARY, and the expected collection/progress flow. Swapping this block to the wrapper keeps the guide aligned with the documented harness.♻️ Suggested edit
- tests/integration/.venv/bin/python -m pytest <focused-scenario> -q - VALGRIND=1 VALGRIND_STRICT=1 \ - tests/integration/.venv/bin/python -m pytest <focused-scenario> -q + ./run_tests.py <focused-scenario> + ./run_tests.py --valgrind --valgrind-strict <focused-scenario>Based on learnings, run the in-tree Python integration suite from
tests/integrationusing./setup-venv.shand./run_tests.py.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/fluent-bit/testing.md` around lines 42 - 49, The integration testing example should use the repo’s wrapper instead of calling pytest directly. Update the `testing.md` guidance around the integration flow to show `tests/integration/run_tests.py` as the primary entry point, while keeping the venv setup and build steps, so the documented harness covers `--valgrind`, `--valgrind-strict`, `FLUENT_BIT_BINARY`, and the expected collection/progress behavior.Source: Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@skills/fluent-bit/testing.md`:
- Around line 42-49: The integration testing example should use the repo’s
wrapper instead of calling pytest directly. Update the `testing.md` guidance
around the integration flow to show `tests/integration/run_tests.py` as the
primary entry point, while keeping the venv setup and build steps, so the
documented harness covers `--valgrind`, `--valgrind-strict`,
`FLUENT_BIT_BINARY`, and the expected collection/progress behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 752f3ef1-fadf-4afd-8404-6c23df183d8f
📒 Files selected for processing (8)
AGENTS.mdskills/README.mdskills/fluent-bit/README.mdskills/fluent-bit/SKILL.mdskills/fluent-bit/patch-workflow.mdskills/fluent-bit/pipeline-architecture.mdskills/fluent-bit/subsystem-patterns.mdskills/fluent-bit/testing.md
In these days, we're heavily relying on LLMs to develop various features and bug fixes on Windows and macOS platforms.
At the moment, we need to extract our locally stored knowledge on our LLM agents.
In this PR, I added generalized skills from my local agents and slightly modified for Windows exceptions due to lack of runtime testing support on Windows.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit