ci: update GitHub Actions to current major versions - #560
Merged
Conversation
All actions were pinned several majors behind: - actions/checkout v4 -> v7 (4 uses) - actions/setup-node v4 -> v7 (3 uses) - actions/setup-java v4 -> v5 - actions/github-script v4 -> v9 github-script@v4 was the pressing one: it declares `runs.using: node12`, a runtime GitHub retired, and only still ran because the runner silently forced it onto a newer Node. Also drop the `github-token` input from the title check, since the script makes no API calls, and remove trailing whitespace-only lines. No behaviour change is expected: - checkout v7 blocks fork-PR checkout only for `pull_request_target` and `workflow_run`; these workflows use plain `pull_request`. - setup-node v5+ auto-caching keys off a `packageManager` field, which package.json does not set, and every call site already sets `cache: npm`. - The node24 runtime in checkout v5+/setup-java v5/github-script v8+ needs runner >= v2.327.1, well below what GitHub-hosted runners ship. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every action used by the workflows was pinned several majors behind. This brings them all current.
ci.ymlactions/checkout(4 uses)ci.ymlactions/setup-node(3 uses)ci.ymlactions/setup-javapublish-open-vsx.yamlactions/checkout,actions/setup-nodesemantic-commit.yamlactions/github-scriptgithub-script@v4was the pressing one. It declaresruns.using: node12, a runtime GitHub retired, and only still ran because the runner silently forced it onto a newer Node — a fallback that can disappear without warning.Also drops the
github-tokeninput from the title check (the script makes no API calls, so it never needed a token) and removes two trailing whitespace-only lines.Why this should be a no-op
Checked against the release notes for each major crossed:
pull_request_targetandworkflow_run. These workflows use plainpull_request.packageManagerfield inpackage.json, which this repo does not set — and every call site already passescache: 'npm'explicitly.require('@actions/github')and redeclaringgetOctokit. The title-check script does neither; it only readscontext.payload.pull_request.titleandprocess.env.regex.Verification
Locally: all four YAML files parse, no
@v4pins remain, and the foldedgithub-scriptbody was syntax-checked and run against the job's regex —fix: somethingandchore: depspass,nope no prefixandfeat:missing spaceare rejected. Unchanged from before.Beyond that this is reasoning from changelogs rather than a green run. CI on this PR is the real test, and it exercises every changed action except the Open VSX publish path, which is tag-triggered and won't run here.
🤖 Generated with Claude Code