chore: remove ignored tests and disconnect test infrastructure - #559
Merged
Merged
Conversation
Remove the three `test.skip` tests that were never run: - rename: "Should rename function" / "Should rename function-use" - implementation: "Should find Dividable trait implementation" Also drop the now-unused `testImplementations` helper, the `normalizeLocation` import it relied on, and the dead `area1`/`area2` markers in the rename test workspace. Remove the `Server disconnect` test and its entire supporting chain: - test file and `disconnect` test workspace - client `simulateDisconnect` command + registration - server `handleDisconnect` handler + notification wiring - the now-dead `apiDisconnect` enum member (both mirrored copies) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes tests that never ran and the disconnect test together with all of its supporting infrastructure.
Ignored (
test.skip) testsShould rename function,Should rename function-useShould find Dividable trait implementationAlso drops code left dead by their removal: the
testImplementationshelper and itsnormalizeLocationimport, plus the/*!area1*///*!area2*/markers in the rename test workspace (verified unused elsewhere; the surviving variable-rename tests self-locate their own markers and are unaffected).Server disconnecttest + infrastructuredisconnecttest workspacesimulateDisconnectcommand and itsflix.simulateDisconnectregistrationhandleDisconnecthandler and itsonNotificationwiringapiDisconnect = 'api/disconnect'enum member, removed from both mirrored copies (client/src/protocol/requests.ts,server/src/engine/jobs.ts)Notes / callouts
apiDisconnectenum member removed entirely. That enum mirrors the Flix compiler's Scala LSP API, soapi/disconnectis a real compiler command — but nothing in this repo sends it anymore, so it would be dead code. The mirror is already non-exhaustive (the client copy omits severallsp/*entries the server has). Happy to restore just those two lines if we'd rather keep it as API documentation.Server disconnectwas the only test exercising the auto-reconnect path, so there is now no test coverage for reconnect.flix.allJobsFinished/flix.checkCounttest commands untouched — they support the other suites' synchronization, not the disconnect test.Verification
tsc --build --force(client + server + test) passes clean.🤖 Generated with Claude Code