add support for Net-Timecode by LaserAnimation - #11
Conversation
|
Hello. I was wondering if this PR could be merged. It was created in coordination with LaserAnimation and was also tested by them. LaserAnimation and I would love to see Net-Timecode support in this great tool. If you have any questions or comments about the code please let me know. |
|
Thanks for this, and sorry it sat for a while. It's a thorough piece of work — the input and the output both follow the existing conventions closely, and the integration into the settings, the interface selectors and the UI was complete, which made merging it much easier than it could have been. Merged into main with your authorship preserved. Two small adjustments on my side, neither of them a problem with your code: I qualified the ByteOrder references as juce::ByteOrder. This project builds with addUsingNamespaceToJuceHeader disabled, so JUCE types need the full namespace here. I don't have LaserAnimation hardware, so I can't verify the protocol on the wire. If you spot anything that needs adjusting once it's out in a build, let me know. |
|
Thank you. |
No description provided.