Solver parameters for conservative tracer transport - #758
Merged
Conversation
jshipton
reviewed
Aug 27, 2026
jshipton
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to specify sensible parameters for the coupled conservative tracer transport equation:
Although this needs to use a
NonlinearVariationalSolver(since themequation has a non-linear time derivative), since we can solve for rho first, the solution should not actually require any non-linear solves.I also do some reorganising of solver parameters for the base
TimeDiscretisationand theExplicitTimeDiscretisation