MMR (mean mixing ratio) limiter update - #754
Merged
Merged
Conversation
tommbendall
requested changes
Aug 13, 2026
tommbendall
left a comment
Contributor
There was a problem hiding this comment.
I spotted one small typo but am otherwise very happy for this. And definitely pleased that the code is now simpler. Well done and thanks Tim!
Co-authored-by: Thomas Bendall <14180399+tommbendall@users.noreply.github.com>
Collaborator
Author
Typo has been fixed. |
tommbendall
approved these changes
Aug 20, 2026
connorjward
pushed a commit
that referenced
this pull request
Aug 26, 2026
Co-authored-by: Thomas Bendall <14180399+tommbendall@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the formulation and implementation of the mean mixing ratio (MMR) limiter. The previous limiter worked in the Terminator Toy test, but uses in other transport tests highlighted an isssue with conservation. The change is to now compute mean fields after transport, rather than transporting the mean fields throughout a single timestep.
This pull request includes the following modifications: