Skip to content

MMR (mean mixing ratio) limiter update - #754

Merged
tommbendall merged 4 commits into
mainfrom
mmr_update
Aug 21, 2026
Merged

MMR (mean mixing ratio) limiter update#754
tommbendall merged 4 commits into
mainfrom
mmr_update

Conversation

@ta440

@ta440 ta440 commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Updates the formulation and implementation of the mean mixing ratio (MMR) limiter. The previous limiter worked in the Terminator Toy test, but uses in other transport tests highlighted an isssue with conservation. The change is to now compute mean fields after transport, rather than transporting the mean fields throughout a single timestep.

This pull request includes the following modifications:

  1. Computes the mean fields after each transport step, rather than transporting the mean fields. This avoids issues with dispersion errors in the lowest order space breaking conservation when blending.
  2. The MMR augmentation does not require a modified residual any more, as the mean fields are not transported, but just computed via projection. This greatly shortens the code!
  3. The limiting kernel uses WR instead of INC for lamda (the blending weights) to correct an error in the previous version.
  4. The test now is for a transport case, rather than the Terminator Toy, as this is found to be a more thorough test of the limiter.

@tommbendall tommbendall left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted one small typo but am otherwise very happy for this. And definitely pleased that the code is now simpler. Well done and thanks Tim!

Comment thread gusto/spatial_methods/augmentation.py Outdated
Co-authored-by: Thomas Bendall <14180399+tommbendall@users.noreply.github.com>
@ta440

ta440 commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator Author

I spotted one small typo but am otherwise very happy for this. And definitely pleased that the code is now simpler. Well done and thanks Tim!

Typo has been fixed.

@tommbendall
tommbendall merged commit dd3167f into main Aug 21, 2026
5 checks passed
connorjward pushed a commit that referenced this pull request Aug 26, 2026
Co-authored-by: Thomas Bendall <14180399+tommbendall@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants