Skip to content

Use system HDF5 again for macOS #5383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
connorjward wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −10
Draft

Use system HDF5 again for macOS #5383

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6215d66
Revert "Fix firedrake-configure for macOS netCDF build failure (#5299)"
connorjward Aug 24, 2026
4899e7d
empty commit
connorjward Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions scripts/firedrake-configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,6 +845,7 @@ OFFICIAL_ARCHS: Mapping[ArchKey, Arch] = {
"cmake",
"fftw",
"hwloc",
"hdf5-mpi",
"metis",
"openblas",
"openmpi",
Expand All @@ -855,13 +856,13 @@ OFFICIAL_ARCHS: Mapping[ArchKey, Arch] = {
extra_petsc_configure_options=[
# External packages
"--with-fftw-dir=/opt/homebrew",
"--with-hdf5-dir=/opt/homebrew",
"--with-hwloc-dir=/opt/homebrew",
"--with-metis-dir=/opt/homebrew",
"--with-scalapack-dir=/opt/homebrew",
"--with-suitesparse-dir=/opt/homebrew",
"--with-zlib-dir=/opt/homebrew",
"--download-bison",
"--download-hdf5",
"--download-hypre",
"--download-mumps",
"--download-netcdf",
Expand All @@ -876,10 +877,7 @@ OFFICIAL_ARCHS: Mapping[ArchKey, Arch] = {
coptflags=["-O3", "-march=native", "-mtune=native"],
cxxoptflags=["-O3", "-march=native", "-mtune=native"],
foptflags=["-O3"],
extra_env_vars={
"HDF5_DIR": "$PETSC_DIR/$PETSC_ARCH",
"CC": "mpicc",
},
extra_env_vars={"HDF5_DIR": "/opt/homebrew"},
),

(OS.MACOS_ARM64, ScalarType.COMPLEX, IntType.INT32, GPUPlatform.NO_GPU): Arch(
Expand All @@ -899,6 +897,7 @@ OFFICIAL_ARCHS: Mapping[ArchKey, Arch] = {
"cmake",
"fftw",
"hwloc",
"hdf5-mpi",
"metis",
"openblas",
"openmpi",
Expand All @@ -911,13 +910,13 @@ OFFICIAL_ARCHS: Mapping[ArchKey, Arch] = {

# External packages
"--with-fftw-dir=/opt/homebrew",
"--with-hdf5-dir=/opt/homebrew",
"--with-hwloc-dir=/opt/homebrew",
"--with-metis-dir=/opt/homebrew",
"--with-scalapack-dir=/opt/homebrew",
"--with-suitesparse-dir=/opt/homebrew",
"--with-zlib-dir=/opt/homebrew",
"--download-bison",
"--download-hdf5",
"--download-mumps",
"--download-netcdf",
"--download-pnetcdf",
Expand All @@ -931,10 +930,7 @@ OFFICIAL_ARCHS: Mapping[ArchKey, Arch] = {
coptflags=["-O3", "-march=native", "-mtune=native"],
cxxoptflags=["-O3", "-march=native", "-mtune=native"],
foptflags=["-O3"],
extra_env_vars={
"HDF5_DIR": "$PETSC_DIR/$PETSC_ARCH",
"CC": "mpicc",
},
extra_env_vars={"HDF5_DIR": "/opt/homebrew"},
),

# Sane default configurations for unknown platforms
Expand Down
Loading