Test interpolation of products of coefficient evaluations - #5360
Merged
Conversation
A product of coefficient evaluations on a hexahedron contracts more indices than one sum factorisation can search, and raised NotImplementedError. Cover scalar powers, along with the vector and tensor expressions whose value indices contract the evaluations together. Companion to firedrakeproject/fiat#280. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Reinstall FIAT from pbrubeck/atomic-contraction, which is pbrubeck/sum-factorise plus keeping factorised contractions whole. Interpolating a product of coefficient evaluations exceeds the sum factorisation index limit without it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
pbrubeck
marked this pull request as ready for review
August 18, 2026 12:21
connorjward
previously approved these changes
Aug 18, 2026
pbrubeck
commented
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion to firedrakeproject/fiat#280, which is stacked on firedrakeproject/fiat#269.
Interpolating a product of coefficient evaluations into a tensor-product space contracts more indices than one sum factorisation can search, and raised
NotImplementedError: Too many indices for sum factorisation!. This adds the regression test: scalar powers, which firedrakeproject/fiat#269 fixes, along with the vector and tensor expressions whose value indices contract the evaluations together, which firedrakeproject/fiat#280 fixes.f*f*f,f*f*f*f, CG1 → CG1dot(u, u)*u, vector CG1dot(A, A), tensor CG1inner(A, A), tensor CG1 → CG1The second commit points CI at the FIAT branch and must be dropped before merge.
AI declaration: written with Claude Code (Claude Opus 5).