[topointon-jump]

Credit to Puffin Validator (https://puffin-validator.xyz/pebble)

[github-actions]

 ┌─ ⚡ PERF · e7b2438 vs main@5fc9f9c ─────────────────────────────────
 │ SUITE                               BASELINE          NEW         Δ
 │ replay tps, mainnet               13,665 tps   13,656 tps  ·  -0.07%
 │ bench tps, localnet              898,796 tps  896,833 tps  ·  -0.22%
 │ snapshot load, testnet                4.94 s       4.94 s  ·  -0.03%
 │ epoch boundary, mainnet             163.9 ms     161.8 ms  ·  -1.25%
!│ mem total, mainnet                147.34 GiB   147.34 GiB  ▲   0.00%
!│ mem total, testnet                 84.66 GiB    84.66 GiB  ▲   0.00%
 │ clean compile, firedancer             3.12 s       3.13 s  ·  +0.20%
 │ binary size, firedancer             57.99 MB     58.01 MB  ·  +0.03%
 ├─────────────────────────────────────────────────────────────────────
@@ 0 REGRESSIONS · 2 WARNINGS · 0 IMPROVED · 6 NOISE @@
 └─────────────────────────────────────────────────────────────────────

history · 2 pushes

 ┌─ HISTORY · Δ vs main, per push, newest first ──────────────────────────────────
 │ HEAD         TPS    BENCH     SNAP    EPOCH    MEM·M    MEM·T  COMPILE   BINARY
!│ e7b2438   -0.07%   -0.22%   -0.03%   -1.25%    0.00%    0.00%   +0.20%   +0.03%
!│ 55ea7e8   -0.29%   -0.36%   +0.03%   +0.31%    0.00%    0.00%   -0.44%   +0.04%
 └────────────────────────────────────────────────────────────────────────────────

[Copilot]

🟡 Changes recommended

The auction strategy is rejected by the bundled GUI’s unchanged schema, and the configuration documentation incorrectly claims votes bypass auction batching.

2 open issues

• Update frontend assets to support the auction strategy · New
• Remove incorrect vote exemption claim for auction batching · New

What changed in this PR

Adds an auction scheduling strategy to Firedancer’s pack tile, batching transactions while allowing bundles to remain independently schedulable.

Changes:

• Adds auction timing, compute-unit pacing, and a holding queue for incoming transactions.
• Exposes the strategy through configuration and GUI output.
• Adds queue lifecycle tests and auction metrics with generated schemas and documentation.

File	Description
src/​disco/​pack/​test_pack.c	Tests auction holding, release, deletion, and expiry.
src/​disco/​pack/​fd_pack.h	Declares auction lifecycle and query APIs.
src/​disco/​pack/​fd_pack.c	Implements the holding queue and auction lifecycle.
src/​disco/​pack/​fd_pack_tile.c	Integrates auction timing, pacing, and scheduling.
src/​disco/​metrics/​metrics.xml	Defines auction metrics and end reasons.
src/​disco/​metrics/​generated/​fd_metrics_sample_gen.c	Adds auction metric serialization.
src/​disco/​metrics/​generated/​fd_metrics_pack.h	Adds generated metric offsets and definitions.
src/​disco/​metrics/​generated/​fd_metrics_enums.h	Adds auction-related enum constants.
src/​disco/​metrics/​generated/​fd_metrics_all.c	Registers auction metric metadata.
src/​disco/​gui/​fd_gui_printf.c	Emits the auction strategy name.
src/​disco/​events/​schema/​metrics_pack.json	Adds auction fields to the event schema.
src/​disco/​events/​schema/​events.proto	Adds auction protobuf messages and fields.
src/​app/​shared/​fd_config.c	Accepts the auction strategy setting.
src/​app/​firedancer/​config/​default.toml	Documents the new strategy option.
book/​api/​metrics-generated.md	Documents the generated auction metrics.

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

The tests do not exercise bulk promotion with multiple entries, including a penalty treap, leaving transaction preservation and account-conflict enforcement unverified for the new traversal.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Test bulk promotion from treaps with shared-account conflicts

src/​disco/​pack/​test_pack.c:1755

This only promotes one held transaction; the later three-transaction case deletes or expires every entry before ending the auction. Consequently, the new traversal that clears the source treap and reinserts its nodes is never exercised with multiple entries. Please add a bulk-promotion case, including enough shared-account transactions to enter a penalty treap, then verify the pack and drain it to check that no entries are lost and account conflicts remain enforced.

2 resolved since last review

• Update frontend assets to support the auction strategy
• Remove incorrect vote exemption claim for auction batching

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

The auction-flush tests leave multi-entry traversal and conflict tracking untested; coverage should verify priority order and blocking of transactions sharing writable accounts until the preceding microblock completes.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Test multi-entry auction flush traversal and conflict tracking

src/​disco/​pack/​fd_pack.c:3025

test_next_auction flushes only one transaction; its multi-entry case deletes or expires every entry before ending the auction. This leaves multi-entry traversal and conflict tracking during the flush untested. Add a case with multiple held transactions sharing writable accounts, then verify priority order and that conflicting work stays blocked until the preceding microblock completes.

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

An unpublished mismatch between the metric’s documented cutoff and its actual trigger requires human assessment of its impact on exported documentation and schema.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Timing-sensitive interactions among auction deadlines, CU pacing, bundle arrivals, and leader-slot transitions require representative runtime/load validation beyond the queue-focused unit test.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Human assessment is needed because auction-end tests leave multi-transaction transfers, shared-account allocation, and penalty handling untested, so transaction preservation and conflict enforcement remain unverified.

No open issues 🎉

_{Review effort: Balanced}