Skip to content

chore(auth,windows): clean up logs #18433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lyokone merged 2 commits into from
Jul 13, 2026
+2 −5
Merged

chore(auth,windows): clean up logs #18433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e57d93
chore(auth,windows): clean up logs
Lyokone Jul 13, 2026
7e1765d
clean
Lyokone Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/firebase_auth/firebase_auth/windows/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ apply_standard_settings(${PLUGIN_NAME})
set_target_properties(${PLUGIN_NAME} PROPERTIES
CXX_VISIBILITY_PRESET hidden)
target_compile_definitions(${PLUGIN_NAME} PUBLIC FLUTTER_PLUGIN_IMPL)
# Enable firebase-cpp-sdk's platform logging api.
# Enable Firebase C++ SDK internal APIs used by App::RegisterLibrary.
target_compile_definitions(${PLUGIN_NAME} PRIVATE -DINTERNAL_EXPERIMENTAL=1)

# Source include directories and library dependencies. Add any plugin-specific
Expand Down
5 changes: 1 addition & 4 deletions packages/firebase_auth/firebase_auth/windows/firebase_auth_plugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#include "firebase/app.h"
#include "firebase/auth.h"
#include "firebase/future.h"
#include "firebase/log.h"
#include "firebase/util.h"
#include "firebase/variant.h"
#include "firebase_auth/plugin_version.h"
Expand Down Expand Up @@ -65,9 +64,7 @@ void FirebaseAuthPlugin::RegisterWithRegistrar(
nullptr);
}

FirebaseAuthPlugin::FirebaseAuthPlugin() {
firebase::SetLogLevel(firebase::kLogLevelVerbose);
}
FirebaseAuthPlugin::FirebaseAuthPlugin() = default;

FirebaseAuthPlugin::~FirebaseAuthPlugin() = default;

Expand Down
Loading