Do not install torch 2.13 on Windows#23
Open
lassoan wants to merge 1 commit into
Open
Conversation
torch 2.13 ships PEP 639 license files that reproduce PyTorch's vendored source tree inside torch-<version>.dist-info/licenses. The deepest collected path is 162 characters relative to site-packages, while Windows limits directory creation to MAX_PATH-12 (248 characters). Installation therefore fails with "[WinError 206] The filename or extension is too long" whenever the path of site-packages is longer than 86 characters, which a default Slicer installation is exactly at. The failed installation leaves a partially extracted torch package behind that is hard to remove, because deleting those files hits the same path length limit. Exclude torch 2.13.* on Windows, along with torchvision 0.28.*, which requires torch 2.13 and would pull it back in. This can be reverted once PyTorch no longer collects the deeply nested license files. See Slicer/light-the-torch#176 and pytorch/pytorch#185813.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torch 2.13 ships PEP 639 license files that reproduce PyTorch's vendored source tree inside torch-.dist-info/licenses. The deepest collected path is 162 characters relative to site-packages, while Windows limits directory creation to MAX_PATH-12 (248 characters). Installation therefore fails with "[WinError 206] The filename or extension is too long" whenever the path of site-packages is longer than 86 characters, which a default Slicer installation is exactly at. The failed installation leaves a partially extracted torch package behind that is hard to remove, because deleting those files hits the same path length limit.
Exclude torch 2.13.* on Windows, along with torchvision 0.28.*, which requires torch 2.13 and would pull it back in. This can be reverted once PyTorch no longer collects the deeply nested license files.
See Slicer/light-the-torch#176 and pytorch/pytorch#185813.