You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We were not able to confirm what changes occurred before and after the application of this PR.
I am observing the area shown by the screenshot below, is this correct?
Is the change so subtle that it is difficult to see with the eyes?
kaorahi
pushed a commit
to kaorahi/lizzie
that referenced
this pull request
Feb 17, 2021
I tried (;B[aa]) with normal UI + default config.
The line from the first move to the second move was thicker than usual. This thickness seems to depend on the value of "Winrate Stroke Width".
I had this setting set to "1" so I couldn't seem to find any difference.
The method of verification was insufficient. I would like to keep in mind to use the default config when checking for bugs.
I tried a little more verification.
If you create a branch like the one on the left, it will be a dotted line, but this also happened even if you set the Winrate Stroke Width to "1".
Next, look at the figure on the right.
In this way, when the movement of the main tree is fixed at "1", the subbranch line seems to be a "thick wrong line" forever.(Only if the current move exists in the root node or in the "1" move of the main tree.)
This PR seems to solve these as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.