Skip to content

Escape backslashes - #2546

Open
mattn wants to merge 1 commit into
fatih:masterfrom
mattn:fix-escape
Open

Escape backslashes#2546
mattn wants to merge 1 commit into
fatih:masterfrom
mattn:fix-escape

Conversation

@mattn

@mattn mattn commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

Completion of :GoImport does not work since the path is not escaped.

@bhcleek

bhcleek commented Oct 22, 2019

Copy link
Copy Markdown
Collaborator

I'm having a hard time find a failure mode for the current implementation. How can I duplicate the problem that this PR solves?

@mattn

mattn commented Oct 22, 2019

Copy link
Copy Markdown
Contributor Author

As far as I walked issues, there are no filed issues will be fixed by this PR.

@bhcleek

bhcleek commented Oct 22, 2019

Copy link
Copy Markdown
Collaborator

Have you seen a problem in the wild? I'm trying to figure out how to duplicate the problem that this would fix 🤔

@bhcleek

bhcleek commented Mar 22, 2020

Copy link
Copy Markdown
Collaborator

@mattn Is this trying to solve a problem on Windows?

Is '\\' necessary or can it be shortened to '\'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants