migrate da strategy provider to alkaid - #1518
Conversation
9ec0cb9 to
012cad5
Compare
2939379 to
d2449a3
Compare
JanFSchulte
added
please test
calad0i
added
please test
calad0i
added
please test
|
The |
|
Weird. Locally I didn't see the same issue. Could be keras version interacting? Checking |
36e4e65 to
a67e50b
Compare
calad0i
added
please test
| options = {'hard_dc': hard_dc, 'search_all_decompose_dc': True} | ||
| inp = FixedVariableArray.from_kif(k, i, f, HWConfig(1, -1, -1), solver_options=options) | ||
| options: solver_options_t = {'hard_dc': hard_dc, 'search_all_decompose_dc': True} | ||
| inp = FVArray.from_kif(k, i, f, solver_options=options) |
There was a problem hiding this comment.
Here you are dropping the HWConfig argument. I see that the default in alkaid is HWConfig(1, 1, -1), so different from what was passed here before. Just checking if that is an intended change.
There was a problem hiding this comment.
This is intended; the parameter is used for alkaid internal surrogate, and the config changed
|
|
||
| fn_cpp = f'{namespace}::{fn_name}<{inp_t}, {out_t}>({inp_name}, {out_name});' | ||
| # When there's multiple inputs, make a wrapper doing the concatenation and rename the original fn. | ||
| if len(inp_names) > 1: |
There was a problem hiding this comment.
I think it would be good to add a test for the multi-input case.
There was a problem hiding this comment.
@calad0i can you comment why this case is not really reachable at the moment for the record? I'm fine with merging without the test, but would like to have it documented.
There was a problem hiding this comment.
It can be reachable by any new layer implementation, like any transformer blocks. But those are already registered in hls4ml,and you need to patch to disable the current path to enable fallback. Or, some new layer is to be proposed and implemented.
2 participants
Description
Replacing da strategy provider
da4mltoalkaid. No user facing breaking changes except for installing alkaid instead of da4ml.Type of change
Tests
Added da fallback implementation of LUT layer and QGRU layer.
Test Configuration:
Checklist