Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
Author
|
We close this PR. We will split the 8.1 work again into fewer and larger PRs, to make the review easier. A new PR will replace this PR. The branch stays. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 10 of 13 of the 8.1 stack (PR 10, item 13). Base: PR 9.
Summary
A managed project has one file,
static-publish.project.js, in the project dir. It is the base of managed mode.Changes
2,config-invalid).static-publish.rc.jsat the top level, the fields ofpublish-content.config.jsinpublishContent, and the settings of the generated app inmanaged(name,description,authors,serviceId,staticPublishVersion). Type:StaticPublishProject.publish-content,collections, andcleanread it in the project dir.publish-content --configreplacespublishContentfor one run.managed.serviceIdis a source of the Service ID for the purge, after the flag andFASTLY_SERVICE_ID, beforefastly.toml.scaffold --managedmakes the sameAppConfigas an ejected scaffold, and writes it as the project file (renderProjectFile()). It adds/.static-publish/and the working dir to the.gitignoreof the project dir, under a comment, and never changes the user's lines.appConfigFromProject()gives the sameAppConfigback.staticPublisherWorkingDirhas a new rule in both modes: a relative path that starts with./or../, and that is not the directory of the config file or a directory above it. A value that breaks the rule now stops the command. Before, the loader ignored the error.Changes after the rebase onto 8.0.0
collections deleteuses it too, and addsmanaged.serviceId.test/e2e/managed-project.test.jsexpects 12 files (the fixture of 8.0 fixes: purge after collections delete, --local in S3 mode, and duplicate variants #113).Review points
staticPublisherWorkingDiris security-relevant. Please review it. It is also a behavior change for an ejected app with a working dir that breaks the rule.managed.authors: onlyauthors[0]is used.Tests
generateApp()then makes the same files.npm teston this branch: 267 passed.managed-project.test.js: 9 passed.Docs
CHANGELOG, README, the modes in
CLAUDE.md, and "Managed projects" insrc/cli/CLAUDE.md.🤖 Generated with Claude Code