Skip to content

Extract reusable functions for non-recursive external $ref schemas #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jagould2012 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Extract reusable functions for non-recursive external $ref schemas #836

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3948226
Force use of cache for $ref objects
jagould2012 Apr 9, 2026
5d8b2e2
Apply suggestions from code review
Eomm Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ function buildObject (context, location, input) {
const jsonPointer = location.jsonPointer || ''
const fullPath = `${schemaId}#${jsonPointer}`

if (context.recursivePaths.has(fullPath) || context.buildingSet.has(schema)) {
if (context.recursivePaths.has(fullPath) || context.buildingSet.has(schema) || (schemaId && schemaId !== '')) {
Comment thread
Eomm marked this conversation as resolved.
Outdated
const functionName = generateFuncName(context)
context.functionsNamesBySchema.set(schema, functionName)

Expand Down Expand Up @@ -627,7 +627,7 @@ function buildArray (context, location, input) {
const jsonPointer = location.jsonPointer || ''
const fullPath = `${schemaId}#${jsonPointer}`

if (context.recursivePaths.has(fullPath) || context.buildingSet.has(schema)) {
if (context.recursivePaths.has(fullPath) || context.buildingSet.has(schema) || (schemaId && schemaId !== '')) {
Comment thread
Eomm marked this conversation as resolved.
Outdated
const functionName = generateFuncName(context)
context.functionsNamesBySchema.set(schema, functionName)

Expand Down
Loading