Skip to content

fix: fix memory leak in separator module and replace exit(1) in publicip #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarterLi merged 2 commits into from
Jul 24, 2026
+5 −4
Merged

fix: fix memory leak in separator module and replace exit(1) in publicip #2477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f872b21
PublicIP: replaces exit(1) with proper error status
Jul 23, 2026
2928f65
Separator: fixes memory leakes
Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/detection/publicip/publicip.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ void ffPreparePublicIp(FFPublicIPOptions* options) {
FFNetworkingState* state = &states[options->ipv6];
const char** status = &statuses[options->ipv6];
if (*status != FF_UNINITIALIZED) {
fputs("Error: PublicIp module can only be used once due to internal limitations\n", stderr);
exit(1);
*status = "PublicIp module can only be used once due to internal limitations";
return;
}

state->timeout = options->timeout;
Expand All @@ -25,8 +25,8 @@ void ffPreparePublicIp(FFPublicIPOptions* options) {
uint32_t hostStartIndex = ffStrbufFirstIndexS(&host, "://");
if (hostStartIndex < host.length) {
if (hostStartIndex != 4 || !ffStrbufStartsWithIgnCaseS(&host, "http")) {
fputs("Error: only http: protocol is supported. Use `Command` module with `curl` if needed\n", stderr);
exit(1);
*status = "Only http: protocol is supported. Use `Command` module with `curl` if needed";
return;
}
ffStrbufSubstrAfter(&host, hostStartIndex + (uint32_t) (strlen("://") - 1));
}
Expand Down
1 change: 1 addition & 0 deletions src/modules/separator/separator.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ void ffInitSeparatorOptions(FFSeparatorOptions* options) {

void ffDestroySeparatorOptions(FFSeparatorOptions* options) {
ffStrbufDestroy(&options->string);
ffStrbufDestroy(&options->outputColor);
}

FFModuleBaseInfo ffSeparatorModuleInfo = {
Expand Down
Loading