add rcip_identity to chunkermat#193
Open
tristangdwl wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for RCIP with sys = c I + kern, rather than just I + kern. The c can be specified per edge (e.g. in mixed BVPs).
We do this by simply dividing the kernels for a given row by c, then rescaling the corner system matrix.
Currently c is passed to chunkermat using opts.rcip_identity, but there is probably a more user friendly way to do this.
It may also be worth considering supporting the case c = 0, i.e. First kind equations. That should be a small modification, but I might suggest waiting for a future pull request.