adding data to chunkgraphs and RCIP#192
Open
peter-nekrasov wants to merge 2 commits into
Open
Conversation
peter-nekrasov
requested review from
askhamwhat,
jghoskins,
mrachh and
tristangdwl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed chunkgraph makedatarows to loop over chunks and add data rows to each one. Also added a data setter to the chunkgraph class which does the same. RCIP previously did not do anything involving data, so I added datacs to Rcompchunk and set local data on local chnkrs during RCIP. Also added an nedge property to chunkgraphs.
These features are useful if you are solving BVPs with coefficients that vary along the boundary, or if you want to use strings on a domain with corners (my use case).
All of these features are tested by chunkgraphrcipDataImpedanceTest, which solves an interior Helmholtz impedance problem with variable coefficients on the boundary using a somewhat silly version of the single layer potential. This uses multiple data rows and checks if both source and target data are properly interpolated during RCIP.