fbcode/libspdl, fbcode/spdl/io/lib: add missing <fmt/format.h> includes for fmt 12.2.0 - #1596
Open
frbng wants to merge 1 commit into
Open
fbcode/libspdl, fbcode/spdl/io/lib: add missing <fmt/format.h> includes for fmt 12.2.0#1596frbng wants to merge 1 commit into
frbng wants to merge 1 commit into
Conversation
…es for fmt 12.2.0 Summary: fmt::format() moved out of fmt/core.h in fmt 12.2.0; these files only included fmt/core.h (or no fmt header at all) and relied on fmt::format transitively/implicitly. Add the explicit <fmt/format.h> include across the libspdl/spdl core and cuda subtrees, found via a subsystem sweep after fbcode//spdl/io/lib:_spdl_ffmpeg failed to build. Differential Revision: D112806772
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@frbng has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112806772. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
fmt::format() moved out of fmt/core.h in fmt 12.2.0; these files only
included fmt/core.h (or no fmt header at all) and relied on fmt::format
transitively/implicitly. Add the explicit <fmt/format.h> include across the
libspdl/spdl core and cuda subtrees, found via a subsystem sweep after
fbcode//spdl/io/lib:_spdl_ffmpeg failed to build.
Differential Revision: D112806772