Add networkbench webserver benchmark - #119
Conversation
|
Hi @dpdani! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Because it was my suggestion in one of our meetings, let me just point out that training the binary on the benchmark is not the end goal, it was to establish the upper bound of the benefit of PGO. |
Change-Id: I8e9573f7b53bc97f2d7701ea70dcb7f2499ad5ae
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
This PR adds a benchmark aimed at simulating a realistic webserver workload. The README gives a high-level overview of what's going on inside.
The benchmark has been executed with the
Dockerfilewhich builds CinderX with Meta Python 3.12, enabling LTO+PGO+BOLT and using the benchmark itself as profile information for them. Additionally, the cinderx binary is bundled into the python binary. TheDockerfilesits at the root of the repo because I had to make some changes tosetup.pyto make PGO run networkbench to get profile information, but this may be reworked if the change lands into CinderX otherwise. (Building this Docker image takes a significant amount of time.)This is how I've run the benchmark so far:
I have not tried to mesh this benchmark together with the existing
cinderx/benchmarks/runner.py, since the build process might make it quite distinct, though I'd appreciate feedback on this.Moreover, I'd like to get feedback on the benchmark overall, is this useful for developing cinderx further?