Skip to content

Add networkbench webserver benchmark - #119

Open
dpdani wants to merge 2 commits into
facebookincubator:mainfrom
dpdani:networkbench
Open

Add networkbench webserver benchmark#119
dpdani wants to merge 2 commits into
facebookincubator:mainfrom
dpdani:networkbench

Conversation

@dpdani

@dpdani dpdani commented Jun 25, 2026

Copy link
Copy Markdown

This PR adds a benchmark aimed at simulating a realistic webserver workload. The README gives a high-level overview of what's going on inside.

The benchmark has been executed with the Dockerfile which builds CinderX with Meta Python 3.12, enabling LTO+PGO+BOLT and using the benchmark itself as profile information for them. Additionally, the cinderx binary is bundled into the python binary. The Dockerfile sits at the root of the repo because I had to make some changes to setup.py to make PGO run networkbench to get profile information, but this may be reworked if the change lands into CinderX otherwise. (Building this Docker image takes a significant amount of time.)

This is how I've run the benchmark so far:

docker build . --tag cinderx_networkbench && docker run cinderx_networkbench

I have not tried to mesh this benchmark together with the existing cinderx/benchmarks/runner.py, since the build process might make it quite distinct, though I'd appreciate feedback on this.

Moreover, I'd like to get feedback on the benchmark overall, is this useful for developing cinderx further?

@meta-cla

meta-cla Bot commented Jun 25, 2026

Copy link
Copy Markdown

Hi @dpdani!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@Yhg1s

Yhg1s commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Because it was my suggestion in one of our meetings, let me just point out that training the binary on the benchmark is not the end goal, it was to establish the upper bound of the benefit of PGO.

Change-Id: I8e9573f7b53bc97f2d7701ea70dcb7f2499ad5ae
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 2, 2026
@meta-cla

meta-cla Bot commented Jul 2, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants