Skip to content

feat: Convergence criterion as a plan sequence (#1834) #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yuhta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Convergence criterion as a plan sequence (#1834) #1834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions axiom/optimizer/tests/PlanMatcher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,11 +383,13 @@ class FixedPointMatcher : public PlanMatcherImpl<FixedPointNode> {
}

if (const auto& convergence = match_->convergencePlan()) {
EXPECT_NE(plan.convergenceConfig().plan, nullptr);
EXPECT_EQ(plan.convergenceConfig().plans.size(), 1);
AXIOM_TEST_RETURN_IF_FAILURE
if (!convergence
->match(
plan.convergenceConfig().plan, symbols, /*context=*/nullptr)
plan.convergenceConfig().plans.front(),
symbols,
/*context=*/nullptr)
.match) {
return MatchResult::failure();
}
Expand Down
2 changes: 1 addition & 1 deletion axiom/optimizer/v2/docs/FixedPoint.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ iterations and is seeded from the anchor.
| --- | --- | --- |
| `RecursiveReferenceNode[counter]` | `WorkingTable[counter, latestDelta]` | `StateSourceNode(counter, delta=true)` |
| anchor branch | anchor branch | `VectorStateDeclaration(counter, append=true)` |
| — (synthesized in Translate) | `convergence:` `Aggregate count()` -> `Project eq(count, 0)` | `ConvergenceConfig.plan`: `AggregationNode(count)` -> `ProjectNode(count == 0)` |
| — (synthesized in Translate) | `convergence:` `Aggregate count()` -> `Project eq(count, 0)` | `ConvergenceConfig.plans`: `AggregationNode(count)` -> `ProjectNode(count == 0)` |

`WorkingTableReadMode` also has an `kAccumulated` mode, which emits
`delta=false` — a read of the whole state rather than the last iteration's
Expand Down
Loading