fix: Open a session without a default schema - #1825
Open
PingLiuPing wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only three connector names carry a built-in default schema, a catalog with no default could not be opened at all. The session already sets a schema at any point with
use <catalog>.<schema>, and a qualified table name needs none.With this patch, the missing default now leaves the schema empty and prints what to run instead of refusing to start.
Connector registration also moves inside the handler that turns a user error into an
Error:line. It ran before it, so a bad flag combination or an unusable catalog file terminated on an uncaught exception rather than the clean message the handler was there to give.