Skip to content

feat(exec): Enforce NOT NULL constraints on table writes #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yuhta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(exec): Enforce NOT NULL constraints on table writes #1810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions axiom/connectors/hive/tests/LocalHiveConnectorMetadataTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,10 @@ class LocalHiveConnectorMetadataTest
/*explain=*/false);

auto builder = exec::test::PlanBuilder().values({values});
auto insertHandle = std::make_shared<core::InsertTableHandle>(
velox::exec::test::kHiveConnectorId, handle->veloxHandle());
auto plan = builder.startTableWriter()
.outputDirectoryPath(outputPath)
.targetColumns(table->type())
.insertHandle(insertHandle)
.insertHandle(handle->veloxHandle())
.fileFormat(format)
.endTableWriter()
.planNode();
Expand Down
4 changes: 3 additions & 1 deletion axiom/optimizer/ToVelox.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2319,7 +2319,9 @@ velox::core::PlanNodePtr ToVelox::makeWrite(
VELOX_CHECK(!finishWrite_, "Only single TableWrite per query supported");
auto insertTableHandle =
std::make_shared<const velox::core::InsertTableHandle>(
connectorId, handle->veloxHandle());
connectorId,
handle->veloxHandle(),
/*notNullColumns=*/folly::F14FastSet<std::string>{});
finishWrite_ = {
metadata,
connectorId,
Expand Down
3 changes: 2 additions & 1 deletion axiom/optimizer/tests/TestConnectorQueryTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ class TestConnectorQueryTest : public QueryTestBase,
auto handle = std::make_shared<core::InsertTableHandle>(
kTestConnectorId,
std::make_shared<connector::TestInsertTableHandle>(SchemaTableName{
std::string(connector::TestConnector::kDefaultSchema), tableName}));
std::string(connector::TestConnector::kDefaultSchema), tableName}),
/*notNullColumns=*/folly::F14FastSet<std::string>{});
auto write = std::make_shared<core::TableWriteNode>(
"writenodeid",
source->outputType(),
Expand Down
4 changes: 3 additions & 1 deletion axiom/optimizer/v2/EmitPass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2092,7 +2092,9 @@ velox::core::PlanNodePtr Emitter::emitTableWrite(const TableWrite& tableWrite) {
VELOX_CHECK(!finishWrite_, "Only one TableWrite per query is supported");
auto insertTableHandle =
std::make_shared<const velox::core::InsertTableHandle>(
connectorId, handle->veloxHandle());
connectorId,
handle->veloxHandle(),
/*notNullColumns=*/folly::F14FastSet<std::string>{});
finishWrite_ = FinishWrite{
metadata,
connectorId,
Expand Down
Loading