test(optimizer): Dual-run UnknownStatsJoinTest - #1795
Open
mbasmanova wants to merge 2 commits into
Open
Conversation
Summary: `PlanTest` ran under v1 only. It now runs under both, so every query in the suite has to plan under v2 as well. Half of the plan assertions hold unchanged under both optimizers and stay in `AXIOM_ASSERT_PLAN`. The 10 where v2 produces a different shape use `AXIOM_ASSERT_PLAN_V1`: the query still has to plan under v2, but its shape is not compared. The shapes v2 does not match today: - Subfield-filter pushdown into the scan. - Filters left after constant folding. - `ParallelProject` — v2 emits a single `Project`. Differential Revision: D117696681
Summary: `UnknownStatsJoinTest` ran under v1 only. It now runs under both, so every query in the suite has to plan under v2 as well. 9 of the 12 plan assertions hold under both optimizers unchanged. `twoJoins` needed a `filterIf(!useV2_)`: v2 folds the `rand() < 0.1` filter into the join instead of emitting a separate `Filter`, and the join order the test is about is unaffected. The remaining three use `AXIOM_ASSERT_PLAN_V1` and record a real gap. Two large tables that join only through a third one should hash-join through it. With `syntacticJoinOrder = false`, v1 does that; v2 cross-joins the two and hash-joins the third afterwards, which is the plan v1 produces only when the syntactic order is pinned. bypass-github-export-checks Differential Revision: D117697551
meta-cla
Bot
added
the
CLA Signed
|
@mbasmanova has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117697551. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
UnknownStatsJoinTestran under v1 only. It now runs under both, so every query in the suite has to plan under v2 as well.9 of the 12 plan assertions hold under both optimizers unchanged.
twoJoinsneeded afilterIf(!useV2_): v2 folds therand() < 0.1filter into the join instead of emitting a separateFilter, and the join order the test is about is unaffected.The remaining three use
AXIOM_ASSERT_PLAN_V1and record a real gap. Two large tables that join only through a third one should hash-join through it. WithsyntacticJoinOrder = false, v1 does that; v2 cross-joins the two and hash-joins the third afterwards, which is the plan v1 produces only when the syntactic order is pinned.bypass-github-export-checks
Differential Revision: D117697551