Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions axiom/optimizer/FunctionRegistry.h
Original file line number Diff line number Diff line change
Expand Up @@ -526,12 +526,9 @@ class FunctionRegistry {
const std::vector<std::string>& names,
AggregateEmptyResultResolver resolver);

/// Returns the result of an aggregate function over empty input.
/// If registerCount() was called, returns 0 (as BIGINT) for 'count' function.
/// Otherwise, uses the resolver registered via
/// Returns the result of an aggregate function over empty input. Uses
/// 'count' registered via registerCount() or a resolver registered via
/// registerAggregateEmptyResultResolver().
/// Returns the result of an aggregate function over empty input. Returns 0
/// as BIGINT for the 'count' registered via registerCount(); otherwise uses
/// a resolver registered via registerAggregateEmptyResultResolver().
/// @param name The aggregate function name.
/// @param argTypes The argument types of the aggregate function.
/// @return Non-null Variant with the result for empty input, or null Variant
Expand Down
2 changes: 1 addition & 1 deletion axiom/optimizer/tests/SqlTestBase.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ std::shared_ptr<runner::LocalRunner> SqlTestBase::makeRunner(
/*user=*/"test",
::axiom::sql::presto::ParserOptions{},
connector::ConnectorProperties{}));
auto statement = parser.parse(sql, true);
auto statement = parser.parse(sql);

VELOX_CHECK(
statement->isSelect(), "Only SELECT statements are supported: {}", sql);
Expand Down
Loading
Loading