test: Pin v2 plan shapes in the enforceSingleRow tests - #1781
Open
mbasmanova wants to merge 2 commits into
Open
Conversation
Summary: `AXIOM_ASSERT_PLAN_V1` skips the shape comparison under v2, so a v2 plan that already matches the pinned shape goes unchecked. 14 assertions in `SubqueryTest` were pinned that way even though both optimizers produce the same plan; they now use `AXIOM_ASSERT_PLAN` and hold v2 to the shape as well. The pins that remain are real v2 differences. Differential Revision: D117580754
Summary:
Both tests pinned v1's plan and skipped the comparison under v2, which hid two places where v2 plans better. For
SELECT * FROM region WHERE r_regionkey > (SELECT n_regionkey FROM nation)
v2 carries the comparison as the nested loop join condition, where v1 emits a cross join followed by a Filter and a Project. For the scalar subquery in a projection, v2 puts the one-row `EnforceSingleRow` side on the join's build input; v1 builds on the driving table instead, and Velox buffers the entire build side, so v1's memory grows with that table.
Both tests now assert with `AXIOM_ASSERT_PLAN_V2`. v1 still has to produce a plan, but its shape is no longer compared.
bypass-github-export-checks
Differential Revision: D117583558
meta-cla
Bot
added
the
CLA Signed
|
@mbasmanova has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117583558. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Both tests pinned v1's plan and skipped the comparison under v2, which hid two places where v2 plans better. For
v2 carries the comparison as the nested loop join condition, where v1 emits a cross join followed by a Filter and a Project. For the scalar subquery in a projection, v2 puts the one-row
EnforceSingleRowside on the join's build input; v1 builds on the driving table instead, and Velox buffers the entire build side, so v1's memory grows with that table.Both tests now assert with
AXIOM_ASSERT_PLAN_V2. v1 still has to produce a plan, but its shape is no longer compared.bypass-github-export-checks
Differential Revision: D117583558